Have you implemented OpenMRS? Please participate in the Implementation Site Survey. If you already have, thank you!
Page tree

Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • If using Git/Github and you don'thave admin status:
    1. issue a pull request with a full link to your ticket in the description.
    2. click the "Request Review" option on the ticket to move into the "Code Review (pre commit)" state.
    3. Add a comment linking to your pull request by its url
  • If using Git/Github and you do do have admin status:
    1. Commit/push to your fork, issue a pull request, and merge the request. (put a full link to your ticket in the description)
    2. Click "Committed Code" in the ticket to move into the "Code Review (post commit)"
  • If using SVN and do do you have commit rights:
    1. Commit to svn with a link to your ticket id
    2. Click "Committed Code" in the ticket
    3. Open a new review in crucible
    4. Add comment to the ticket linking to the full crucible url
  • If using SVN and don'tyou have commit rights:
    1. Create a patch of your changes
    2. Click "Request Review" button in the ticket to go into "Code Review (pre commit)"
    3. Attach your patch file to the ticket
    4. If the ticket is large, open a new review in crucible
    5. Add comment to the ticket linking to the full crucible url

...

Doing the code review

Go through the code SLOWLY with a mind towards the Goals of Code Review (see below) and the Code Review Checklist

...