2010-03-01 Code Review

In Attendance

  • Darius Jazayeri
  • Sy Haas
  • Wyclif Luyima
  • Jeremy Keiper
    <!--
  • Sy Haas
  • Wyclif Luyima
  • Jeremy Keiper
    -->

Patches Reviewed

Ticket #2052

  • should have been marked "approved, pending minor change" instead of "needs review"
  • mostly UI-related (JSP)
  • skipping for now

Ticket #2017

  • camel case in @should statements is an OpenMRS taboo
  • TODO: when applying do not remove OrderTest.java
  • TODO: do not unnecessarily change the format of the UserFormControllerTest
  • changed status to approved

Ticket #2090

  • approved