Wiki Spaces

Documentation
Projects
Resources

Get Help from Others

Q&A: Ask OpenMRS »
Discussion: OpenMRS Talk »
Real-Time: IRC Chat

IRC Logs

Child pages
  • 2009-07-27 - OpenMRS
Skip to end of metadata
Go to start of metadata
00:15:17 *** Agnor has quit IRC
00:21:11 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9414]: facility data: make the date format be: yyyy/MM/dd vs. using the … <http://dev.openmrs.org/changeset/9414>
00:32:09 *** atomicturtle1 has joined #openmrs
00:32:09 *** atomicturtle has quit IRC
00:42:17 *** jmiranda has joined #openmrs
00:42:17 *** ChanServ sets mode: +o jmiranda
00:53:13 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9415]: facility data: few changes that were forgotten in the switch from locale … <http://dev.openmrs.org/changeset/9415>
01:22:51 *** jmiranda has quit IRC
01:40:22 <r0bby> I wish my CSS skills were better :(
01:50:43 *** jmiranda has joined #openmrs
01:50:44 *** ChanServ sets mode: +o jmiranda
01:57:17 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9416]: facility data: use the @RequestParam and use the editor. <http://dev.openmrs.org/changeset/9416>
02:12:07 <r0bby> bwolfe: do you have issues where the jquery ui dialog doesn't display after the first time...
02:12:10 <r0bby> :/
02:28:30 *** bwolfe has quit IRC
02:29:57 *** upul has joined #openmrs
02:29:57 *** ChanServ sets mode: +v upul
02:40:43 <r0bby> !bughunting--
02:59:23 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9417]: facility data: add the ability to load a report for an arbitrary period. <http://dev.openmrs.org/changeset/9417>
03:31:23 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9418]: facility data: finish up the conversion from locale-specific DateFormat to … <http://dev.openmrs.org/changeset/9418>
03:31:23 *** atomicturtle1 has quit IRC
03:32:10 *** atomicturtle has joined #openmrs
03:44:18 *** jmiranda_ has joined #openmrs
03:46:27 *** jmiranda has quit IRC
05:23:44 *** jacobb has quit IRC
05:23:44 *** jmiranda_ has quit IRC
05:28:13 *** jmiranda_ has joined #openmrs
05:28:35 *** jacobb has joined #openmrs
05:39:28 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9419]: facility data: some layout tweaks -- still not 100% pleased <http://dev.openmrs.org/changeset/9419>
06:11:29 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9420]: facility data: small display tweaks <http://dev.openmrs.org/changeset/9420>
06:31:38 *** atomicturtle1 has joined #openmrs
06:31:38 *** atomicturtle has quit IRC
06:42:17 *** pascal` has joined #openmrs
06:43:05 <pascal`> upul, Echidna_, Mkop, all
06:44:07 <Mkop> howzit pascal`
06:44:12 <upul> Hi pascal`
07:57:33 *** danielf has joined #openmrs
07:57:40 <pascal`> hi danielf
07:57:56 <danielf> morning pascal`
07:58:53 <pascal`> have you tried xchat?
07:59:05 <pascal`> are you running a microsoft OS?
07:59:15 <danielf> yep, had it installed on my old laptop, before it crashed
07:59:30 <danielf> ye, windows
07:59:31 <pascal`> =S
07:59:48 <danielf> waiting for new machine to reinstall xchat
08:00:12 <pascal`> aren't we all... :P
08:00:52 <danielf> hehe :)
08:22:15 *** danielf has quit IRC
08:25:30 *** danielf has joined #openmrs
08:28:31 *** danielf has quit IRC
09:28:22 *** Echidna_ is now known as Echidna
09:31:28 *** atomicturtle has joined #openmrs
09:31:28 *** atomicturtle1 has quit IRC
09:53:48 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9421]: xforms module: bug fixes on form designer and adding support for editing … <http://dev.openmrs.org/changeset/9421>
10:24:55 *** jacobb has quit IRC
10:24:56 *** jmiranda_ has quit IRC
10:25:07 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: XForms 2.8 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=xforms&version=&2.8>
10:25:29 *** jmiranda_ has joined #openmrs
10:26:06 *** jacobb has joined #openmrs
10:52:05 *** Mkop has quit IRC
10:52:49 *** Mkop has joined #openmrs
10:53:03 *** Mkop has quit IRC
11:13:46 *** kane77 has joined #openmrs
11:29:27 *** upul has quit IRC
11:30:31 *** james_regen has joined #openmrs
11:30:31 *** ChanServ sets mode: +v james_regen
11:48:53 *** mkulumadzi has joined #openmrs
11:49:53 <pascal`> hey mkulumadzi
11:51:05 <mkulumadzi> hi pascal
12:32:39 *** nribeka has quit IRC
12:32:39 *** atomicturtle has quit IRC
12:33:00 *** atomicturtle has joined #openmrs
12:44:47 *** nribeka has joined #openmrs
12:44:47 *** ChanServ sets mode: +v nribeka
12:46:52 <pascal`> hey nribeka
12:47:00 <nribeka> hi pascal
12:48:17 *** nribeka_ has joined #openmrs
12:52:50 *** bwolfe has joined #openmrs
12:52:50 *** ChanServ sets mode: +o bwolfe
12:54:21 <pascal`> good monday morning bwolfe
12:54:37 <bwolfe> hi pascal
13:00:17 *** atomicturtle has quit IRC
13:03:49 *** catechu has joined #openmrs
13:06:35 *** nribeka has quit IRC
13:08:37 *** jmiranda_ has quit IRC
13:08:39 *** ChanServ sets mode: +v nribeka_
13:08:46 *** nribeka_ is now known as nribeka
13:27:06 *** atomicturtle has joined #openmrs
13:31:36 *** jmiranda_ has joined #openmrs
13:33:11 <pascal`> hey jmiranda_
13:33:27 <jmiranda_> hey pascal`
13:33:48 *** jmiranda_ is now known as jmiranda
13:33:57 *** ChanServ sets mode: +o jmiranda
14:05:51 *** djazayeri has joined #openmrs
14:05:51 *** ChanServ sets mode: +o djazayeri
14:08:00 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9423]: occmodule: Deleting jars so they are referenced from openmrs-1.5.x branch <http://dev.openmrs.org/changeset/9423> || OpenMRS Changesets: Changeset [9422]: ncd: Added tests for Icd9InObxCritic. Added code to populate the … <http://dev.openmrs.org/changeset/9422>
14:23:28 *** Val`EDUniv has joined #openmrs
14:40:03 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9424]: occmodule: Fixed .classpath file to reference 1.5.x branch project jars <http://dev.openmrs.org/changeset/9424>
14:44:15 *** jmiranda has quit IRC
14:56:28 *** pascal` has quit IRC
14:58:11 *** catechu has quit IRC
14:58:55 *** jmiranda has joined #openmrs
14:58:55 *** ChanServ sets mode: +o jmiranda
15:00:23 *** mkulumadzi has quit IRC
15:14:00 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9425]: Fixing LazyInitializationException related to user properties on patient … <http://dev.openmrs.org/changeset/9425> || OpenMRS Tickets: Ticket #1604 (defect closed): ConversionException during deserialization of a saved cohort definition <http://dev.openmrs.org/ticket/1604#comment:5> || OpenMRS Tickets: Ticket #1608 (defect closed): CannotResolveClassException: org.openmrs.User$$EnhancerByCGLIB$$fff1cb7 <http://dev.openmrs.org/ticket/1608#comment:4>
15:15:40 *** bmckown has joined #openmrs
15:15:40 *** ChanServ sets mode: +o bmckown
15:43:14 *** mkulumadzi has joined #openmrs
15:46:07 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9427]: removing dashes from portletUUID so it may be used as part of a function … <http://dev.openmrs.org/changeset/9427> || OpenMRS Changesets: Changeset [9426]: 1.5.x branch: Fixing LazyInitializationException related to user … <http://dev.openmrs.org/changeset/9426>
15:48:33 *** bmckown has quit IRC
16:31:01 *** catechu has joined #openmrs
16:34:41 *** Agnor has joined #openmrs
16:38:06 <catechu> james_regen: when a demographic field is null, is it always an empty string?
16:38:54 <catechu> or are there other possibilities
16:41:22 <james_regen> i think the code might return an empty string if there's no demographic value
16:43:19 <catechu> ok -- so no strings like 'NULL'?
16:45:31 <james_regen> right, if it's NULL then that's what's in the data
16:46:06 <catechu> ok
16:50:13 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9428]: ncd: Removing link from 6357-8 to Lymphogranuloma venereum and deleting … <http://dev.openmrs.org/changeset/9428>
16:59:55 *** mkulumadzi has quit IRC
17:08:53 *** Mkop has joined #openmrs
17:09:53 *** Mkop has quit IRC
17:37:00 <catechu> james_regen: what are JCS and LEV?
17:46:19 <r0bby> bwolfe: i upgraded to 1.5.x last night and now my OpenMRS instance won't start w/ spring errors :(
17:56:04 *** catechu has quit IRC
18:00:41 <james_regen> catechu: those are different ways to compare strings. LEV is levenshtein edit distance. JCS is . . . something else, i'll have to look i tup
18:01:36 <james_regen> so instead of exact comparisons, where a string is either 0 or 1 in similarity, "tom" and "tim" might be 0.85 similar, and for matching, you might want to accept similarity above 0.8
18:02:50 <r0bby> james_regen: commons lang has methods to do levenshtein edit distance :X
18:06:20 <james_regen> we're using a jar file that has many, many different comparators. i think levenshtein is fairly common, but other like jaro-winkler isn't. the library we're using is from: http://www.dcs.shef.ac.uk/~sam/stringmetrics.html
18:06:23 <OpenMRSBot> <http://ln-s.net/3hif> (at www.dcs.shef.ac.uk)
18:07:33 <r0bby> cool james_regen :)
18:07:53 <bwolfe> r0bby: ok...sorry about that. did you want me to do something about that or are you just complaining? I'm sure you could figure out the problem yourself with your skills by looking at tomcat logs...right?
18:09:09 <r0bby> nevermind forget i said a word
18:09:15 <r0bby> if i hit a snag -- i
18:09:21 <r0bby> 'll ping yo
18:09:22 <r0bby> u
18:13:49 *** amogha has joined #openmrs
18:14:33 *** bmckown has joined #openmrs
18:14:34 *** ChanServ sets mode: +o bmckown
18:15:59 <bwolfe> r0bby: ok, let me know if its something that you can't figure out or if its something others will run into when upgrading.
18:26:18 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9430]: patientmatching module: fixed minor conflicts in dupesList.jsp <http://dev.openmrs.org/changeset/9430> || OpenMRS Changesets: Changeset [9429]: patientmatching module: wrote draft of NullAnalyzer (needs testing) <http://dev.openmrs.org/changeset/9429>
18:35:32 <r0bby> bwolfe: i got that layout issue solved
18:35:45 <r0bby> using the header and footer makes me close off divs twice
18:35:55 <r0bby> sometimes 3 times to make layout oddities go away
18:36:11 <bwolfe> you have to do: <div> </div> </div> ??
18:36:20 <r0bby> yes
18:36:24 <r0bby> hold
18:36:27 <bwolfe> or <div> <div> </div> </div>
18:37:26 <r0bby> http://pastie.org/private/nydcfrvxdnauomuzx8youa
18:37:28 <OpenMRSBot> <http://ln-s.net/3hm2> (at pastie.org)
18:37:55 <r0bby> ... I should probably remove the silence of the lambs quote
18:38:02 <r0bby> i got goofy one night
18:40:09 <bwolfe> r0bby: why are you doing this open+close divs: <div style="margin: 0 20 5 0;float:left;"/> ?
18:41:46 <r0bby> that was i believe darius (i mostly used the markup from their legacy system (tweaking where it was necessary
18:42:21 <r0bby> it looks like this: http://openmrs.org/wiki/Image:DailyReportCalendar.jpg
18:42:22 <OpenMRSBot> <http://ln-s.net/3g7D> (at openmrs.org)
18:42:28 <r0bby> the box on the left
18:42:47 <r0bby> the calendar isn't spaced like that on mine -- but im not gonna worry about it :)
18:43:12 <r0bby> anyways have a good day
18:43:16 <r0bby> i gotta go get ready
18:52:11 *** atomicturtle has left #openmrs
18:58:23 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Support for groupers other than encounter? (Pregnancy, episo <http://forum.openmrs.org/viewtopic.php?f=11&t=480#p1756>
19:30:27 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9432]: -- chica * updated PSF WIC rule priority <http://dev.openmrs.org/changeset/9432> || OpenMRS Changesets: Changeset [9431]: facility data: tweaks + remove a silence of the lambs quote <http://dev.openmrs.org/changeset/9431>
19:49:52 *** atomicturtle has joined #openmrs
19:55:56 *** nribeka has left #openmrs
19:56:08 *** nribeka has joined #openmrs
20:02:32 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9436]: Fixing #1678 - Modal view of form instance data within UI <http://dev.openmrs.org/changeset/9436> || OpenMRS Changesets: Changeset [9435]: reporting: Add default Collection Handler for editing cohort definitions <http://dev.openmrs.org/changeset/9435> || OpenMRS Changesets: Changeset [9434]: schedulerquartz: parameters changed for email templates <http://dev.openmrs.org/changeset/9434> || OpenMRS Changesets: Changeset [9433]: reporting: Add default Collection Handler for editing cohort definitions <http://dev.openmrs.org/changeset/9433>
20:05:33 *** catechu has joined #openmrs
20:12:01 *** james_regen has quit IRC
20:13:23 *** ChanServ sets mode: +v nribeka
20:28:44 *** djazayeri has quit IRC
20:34:31 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9438]: 1.5.x: Followup js fix to patientEncounter portlet for view encounter … <http://dev.openmrs.org/changeset/9438> || OpenMRS Changesets: Changeset [9437]: 1.5.x branch: Fixing #1678 - Modal view of form instance data within UI <http://dev.openmrs.org/changeset/9437>
20:53:26 *** catechu has quit IRC
20:56:48 <r0bby> bwolfe: Caused by: java.lang.NoClassDefFoundError: javassist/util/proxy/MethodFilter
20:57:33 <bwolfe> r0bby: (I'm assuming this is the startup error you mentioned before) I think thats caused by the hibernate version
20:57:40 <r0bby> http://pastie.org/private/ttkhvru7dh1dgfmvt3bfg
20:57:42 <r0bby> yeh
20:57:48 <r0bby> that is
20:58:00 <r0bby> the start up error
20:58:04 <r0bby> what should i do?
20:58:13 <r0bby> I'm running the latest svn
20:58:21 <bwolfe> are you providing that jar in your module?
20:58:30 <r0bby> lib-common
20:58:38 <r0bby> which if i remember right isn't in the omod
20:59:14 <r0bby> i provide no jars
20:59:21 <r0bby> well i do
20:59:26 <r0bby> but not hibernate
20:59:28 <bwolfe> r0bby: you're providing the newer hibernate...
20:59:38 <r0bby> no im not
20:59:54 <bwolfe> nothing is in your module's lib dir?
21:00:09 <r0bby> google collections and standard.jar
21:00:17 <r0bby> that's it
21:00:23 <r0bby> (I like google collections)
21:00:30 <r0bby> that's it
21:00:36 <r0bby> brb need more splenda in my coffee
21:00:38 <bwolfe> what other modules do you have ?
21:04:03 <r0bby> hrm
21:04:18 <r0bby> stuff that came packaged with the war
21:04:24 <r0bby> when i threw the beta in
21:04:33 <r0bby> (i didnt use em )
21:04:41 <r0bby> lemme see if i can axe those
21:04:44 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9439]: Followup js fix to patientEncounter portlet for view encounter popup - … <http://dev.openmrs.org/changeset/9439>
21:04:47 <r0bby> gotta figure out wher ethe hell they are
21:05:57 <r0bby> hrm nothing else
21:07:41 <r0bby> yeh just opened my omod -- no hibernate jars
21:07:51 <r0bby> did the core upgrade?
21:08:14 <r0bby> I could hack up a solution and add javassist?
21:08:19 <bwolfe> r0bby: core has been on the same hibernate jar for a while now
21:08:35 <r0bby> hrm..
21:11:32 <r0bby> http://pastie.org/private/ofwemcl89jfac0dqyetsa
21:11:34 <r0bby> full error
21:12:07 <r0bby> actually no :/
21:12:12 <r0bby> nevermind
21:12:28 <r0bby> i dont get it
21:12:35 <r0bby> it happened only after i upgraded...
21:13:36 <bwolfe> r0bby: so you're using the latest 1.5 beta2 ? or a nightly build? or building trunk from src ?
21:13:55 <r0bby> Im using 1.5.x branch from SVN
21:14:10 <bwolfe> can you start openmrs without your module ? (delete the omod from your applicationdatadir/modules folder and restart tomcat or openmrs)
21:14:19 <r0bby> hold
21:15:22 <r0bby> hrm
21:17:19 <r0bby> lemme try and reset up things
21:21:13 <r0bby> okay wtf
21:21:20 <r0bby> i can't find where it's looking :/
21:21:44 <r0bby> i deleted the runtime properties.. where is it getting connection details :/
21:27:15 <r0bby> lemme see if trunk runs better
21:32:59 <bwolfe> r0bby: openmrs prints where its getting the runtime properties into the tomcat log files. look at that right after you start up.
21:33:18 <bwolfe> r0bby: its probably not your database, so resetting that is probably not useful
21:33:38 <bwolfe> r0bby: just delete your modules and see if you can load openmrs with your database that you upgraded
21:40:49 <r0bby> it didnt
21:40:58 <r0bby> ok trunk loaded
21:41:23 <r0bby> I'll be working off of trunk it seems
21:41:33 <r0bby> if a module runs on trunk chances are it runs on 1.5.x right?
21:42:00 <bwolfe> r0bby: correct
21:43:07 <r0bby> good im not gonna run 1.5.x anymore then
21:43:29 *** atomicturtle has left #openmrs
21:44:30 <r0bby> I *DO* know this wont run on anything pre 1.5.x
21:44:42 <bwolfe> r0bby: do you still have the 1.5 openmrs.war compiled from source (or downloaded)? Can you drop that into tomcat and see if it works ?
21:44:57 <r0bby> I can re-gen it
21:45:00 <r0bby> let me do that
21:45:07 <r0bby> let me do a clean build
21:45:38 <r0bby> (I hope this isn't something i discovered accidentally)
21:46:02 <r0bby> I need to stop sleeping all day :|
21:46:49 *** kane77 has quit IRC
21:47:05 <r0bby> bwolfe: heads up -- save msg i gave burke: the IDEA license expires July 27 2010
21:47:23 <r0bby> I updated my license
21:47:30 <bwolfe> r0bby: sucks for you. guess you'll have to use a better IDE now ;-)
21:47:43 <bwolfe> oh, nm, 2010?
21:47:47 <r0bby> 2010 yes
21:48:08 <r0bby> It will expire mid program if i participate again so it becomes more dire that it get renewed earlier
21:48:25 <bwolfe> r0bby: I've never touched IDEA or its license...so it means nothing to me. :-)
21:48:35 <r0bby> bmckown uses it
21:48:46 <r0bby> so he cares
21:48:49 <bwolfe> you and he are the only two
21:48:56 <r0bby> I love it :)
21:49:03 <bmckown> it's great.
21:49:05 <bwolfe> bwolfe != bmckown :-p
21:49:19 <r0bby> bwolfe: you're missing out
21:49:21 <r0bby> try it
21:49:29 <r0bby> just not using the new G1 Garbage Collector
21:49:36 <r0bby> that shit will crash like a mofo
21:49:56 <bwolfe> eclipse does 110% of the things I need. I have exactly 0 complaints with it...no reason to switch
21:50:28 <r0bby> bmckown: do you use the IDEA 9 EAP?
21:50:52 <bmckown> just downloaded it an hour ago
21:51:14 <r0bby> the background indexing is godly
21:51:46 <bmckown> it seems to be a bit faster.
21:51:58 <r0bby> slightly
21:52:24 <r0bby> it annoys me that it always *NAGS* me to import the namespaces for JSPs
21:53:15 <bmckown> i just ignore the import nags.... but now i see... you can background the startup indexing... that *is* godly
21:53:53 <r0bby> I find it easier to just oblige
21:54:23 <r0bby> it allows me to specify my message.properties messages :)
21:55:28 <r0bby> bmckown: did you figure out how to do remote debugging yet?
21:55:55 <r0bby> Run/Debug dialog -> Add tomcat server
21:56:05 <bmckown> no, haven't gotten to it yet. I understand u said start up jvm in debug mode first.
21:56:08 <r0bby> then set up the debugging from there (the UI is pretty easy to figureout)
21:56:19 <bmckown> i see. i'll give it a try.
21:56:20 <r0bby> Start -> Run
21:56:22 <r0bby> cmd /c "C:\Program Files\Apache Software Foundation\Tomcat 6.0\bin\catalina.bat" jpda start
21:56:34 <r0bby> or similar under linux
21:56:54 <r0bby> Windows Key + R (on vista)
21:57:53 <r0bby> hold on
21:58:40 <r0bby> go to the server config in the run/debug dialog; Startup/Connection and select debug
21:58:45 <r0bby> the rest is straight forward
21:58:53 <r0bby> screen shot forth coming
22:01:50 <r0bby> http://img9.imageshack.us/img9/361/50235866.png
22:02:23 <r0bby> that's how i have it set up
22:02:42 <r0bby> just run it w/ the command i did w/ that setup and you're gold
22:02:52 <r0bby> then just select that configuration and select "Debug"
22:03:06 <r0bby> er click the debug icon
22:04:47 <bmckown> oh, i see... you run tomcat instance from within the ide
22:05:32 <bmckown> i will try... hopefully idea supports sudoing to run tomcat.
22:05:33 <r0bby> bmckown: not quite
22:05:39 <r0bby> you can have ti connect to a running instance
22:05:51 <bmckown> ti?
22:06:17 <r0bby> it*
22:06:27 <r0bby> I type too fast for my own good sometimes
22:06:50 <bmckown> okay. yea i want to have it connect to a running instance of tomcat that is in debug mode
22:07:03 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1683 (defect created): Patient Matching Module Required Priviliges <http://dev.openmrs.org/ticket/1683> || OpenMRS Changesets: Changeset [9440]: reporting: Minor fixes for Rwanda Reports page <http://dev.openmrs.org/changeset/9440>
22:07:20 <r0bby> bmckown: yup :)
22:07:32 <r0bby> I always run it in debug mode due to the fact i never know when i'll need to debug
22:08:09 <bmckown> i usually don't because the log files are next to impossible to search in debug mode.
22:15:32 <r0bby> bwolfe: heads up i'm making a small non-breaking change to trunk in the DownloadDictionaryServlet
22:16:05 <r0bby> you had: if(c.isRetired() == false) -- i'm changing it to: if(!c.isRetired())
22:18:28 <r0bby> done -- it's a small non-breaking change
22:20:32 *** nribeka has quit IRC
22:22:30 *** bwolfe has quit IRC
22:23:18 <r0bby> curiosity gets the best of me sometimes when looking around OpenMRS :X
22:31:20 <bmckown> ah, very nice, r0bby ... now i'm debugging with idea. thanks!
22:31:39 <bmckown> r0bby++
22:31:45 <r0bby> bmckown: no problem
22:31:56 <r0bby> hopefully that small change i commited doesn't cause me to get flamed :X
22:32:12 <r0bby> seeing things == true and == false makes me get the worst itch ever
22:32:16 *** jmiranda has quit IRC
22:32:32 <bmckown> small change gets 100 robby--
22:32:36 <bmckown> just kidding
22:33:24 *** jmiranda has joined #openmrs
22:33:24 *** ChanServ sets mode: +o jmiranda
22:37:09 <r0bby> If i see the change breaking -- i would do a patch
22:37:34 <r0bby> but for something as silly as if(!c.isRetired()) from if(c.isRetired() == false) isn't worth the effort of a patch and ticket
22:41:58 <bmckown> not worth patch and ticket agreed
22:48:34 *** bmckown has quit IRC
23:05:29 *** nribeka has joined #openmrs
23:05:29 *** ChanServ sets mode: +v nribeka
23:07:00 *** bwolfe has joined #openmrs
23:07:00 *** ChanServ sets mode: +o bwolfe
23:07:26 <Echidna> http://assets.en.oreilly.com/1/event/27/Programmer%20Insecurity%20and%20the%20Genius%20Myth%20Presentation.pdf
23:07:30 <OpenMRSBot> <http://ln-s.net/3hx2> (at assets.en.oreilly.com)
23:07:35 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9442]: schedulerquartz: Added mail libraries to build path. <http://dev.openmrs.org/changeset/9442> || OpenMRS Changesets: Changeset [9441]: non breaking change -- if(c.isRetired() == false) is equivilent to: … <http://dev.openmrs.org/changeset/9441>
23:37:36 *** amogha has quit IRC
  • No labels