Wiki Spaces

Documentation
Projects
Resources

Get Help from Others

Q&A: Ask OpenMRS »
Discussion: OpenMRS Talk »
Real-Time: IRC Chat

IRC Logs

Child pages
  • 2009-07-10 - OpenMRS
Skip to end of metadata
Go to start of metadata
00:10:21 *** nribeka has joined #openmrs
00:10:21 *** ChanServ sets mode: +v nribeka
00:14:02 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9029]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9029> || OpenMRS Changesets: Changeset [9028]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9028> || OpenMRS Changesets: Changeset [9027]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9027> || OpenMRS Changesets: Changeset [9026]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9026> || OpenMRS Changesets: Changeset [9025]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9025> || OpenMRS Changesets: Changeset [9024]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9024> || OpenMRS Changesets: Changeset [9023]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9023> || OpenMRS Changesets: Changeset [9022]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9022> || OpenMRS Changesets: Changeset [9021]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9021> || OpenMRS Changesets: Changeset [9020]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9020> || OpenMRS Changesets: Changeset [9019]: htmlformentry module: creating trunk and 1.4.x branch <http://dev.openmrs.org/changeset/9019> || OpenMRS Changesets: Changeset [9018]: htmlformentry module: splitting into 1.4.x and trunk <http://dev.openmrs.org/changeset/9018>
01:06:33 *** nribeka_ has joined #openmrs
01:12:18 *** nribeka has quit IRC
01:12:22 *** nribeka__ has joined #openmrs
01:27:43 *** scottyaz has joined #openmrs
01:30:34 *** nribeka_ has quit IRC
01:32:11 *** djazayeri has quit IRC
01:50:10 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9030]: htmlformentry-trunk: cleaning up classpath <http://dev.openmrs.org/changeset/9030>
02:12:37 *** upul has joined #openmrs
02:12:37 *** ChanServ sets mode: +v upul
02:54:12 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1627 (defect created): Openmrs 1.5.x locks up during startup <http://dev.openmrs.org/ticket/1627> || OpenMRS Forum: Re: Can't delete patients <http://forum.openmrs.org/viewtopic.php?f=23&t=478#p1745> || OpenMRS Forum: Support for groupers other than encounter? (Pregnancy, episo <http://forum.openmrs.org/viewtopic.php?f=11&t=480#p1744>
03:07:55 *** scottyaz has quit IRC
03:12:41 *** scottyaz has joined #openmrs
03:24:06 *** ChanServ sets mode: +v nribeka__
03:24:10 *** nribeka__ is now known as nribeka
03:26:13 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Searching Encounters <http://forum.openmrs.org/viewtopic.php?f=11&t=479#p1746>
03:27:02 *** scottyaz has quit IRC
03:51:39 *** Amogha has joined #openmrs
03:56:33 *** Amogha has quit IRC
03:56:41 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1158 (task reopened): Filter Encounters by Encounter Types on Patient Dashboard <http://dev.openmrs.org/ticket/1158#comment:9>
03:56:51 *** atomicturtle has joined #openmrs
04:24:38 *** Mkop has joined #openmrs
05:32:18 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Searching Encounters <http://forum.openmrs.org/viewtopic.php?f=11&t=479#p1747>
06:04:20 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9031]: ncd: final piece of AUI-7 - codes, systems and types. <http://dev.openmrs.org/changeset/9031>
06:15:36 *** atomicturtle1 has joined #openmrs
06:15:36 *** atomicturtle has quit IRC
06:36:24 *** pascal` has joined #openmrs
07:08:26 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9032]: facility data: bug fix to load the report values properly. <http://dev.openmrs.org/changeset/9032>
07:40:24 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Can't edit metadata <http://forum.openmrs.org/viewtopic.php?f=23&t=481#p1749> || OpenMRS Forum: Re: Can't delete patients <http://forum.openmrs.org/viewtopic.php?f=23&t=478#p1748>
08:29:39 *** pascal`` has joined #openmrs
08:30:51 *** pascal` has quit IRC
08:39:42 *** pascal`` is now known as pascal`
08:39:45 <pascal`> ohai
08:40:17 <upul> ohayogosaimasu
08:42:23 <pascal`> ohayo gozaimasu upul
08:44:28 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9034]: After removing unnecessary variables <http://dev.openmrs.org/changeset/9034> || OpenMRS Changesets: Changeset [9033]: facility data: add an EL function to retrieve values entered for a given … <http://dev.openmrs.org/changeset/9033>
09:06:24 <r0bby> hai
09:06:51 <upul> hai
09:10:42 <r0bby> ok sleep time then more work then weekend fun
09:14:09 <pascal`> ohai r0bby
09:16:30 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9035]: Updates general use case so that it outputs a CDS and edited the user case … <http://dev.openmrs.org/changeset/9035>
09:21:17 *** atomicturtle has joined #openmrs
09:21:17 *** atomicturtle1 has quit IRC
09:29:17 *** carl___ has joined #openmrs
09:38:22 *** Mkop has quit IRC
09:48:45 *** carl___ has quit IRC
10:20:35 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9036]: xforms module: form designer's proper saving of data values in group … <http://dev.openmrs.org/changeset/9036>
11:25:14 *** upul has quit IRC
11:40:12 *** scottyaz has joined #openmrs
11:48:44 *** scottyaz has quit IRC
11:48:58 *** scottyaz has joined #openmrs
11:49:41 *** nribeka has quit IRC
11:54:41 *** atomicturtle has left #openmrs
11:56:27 *** nribeka has joined #openmrs
11:56:27 *** ChanServ sets mode: +v nribeka
11:57:29 *** scottyaz has quit IRC
11:57:44 *** scottyaz has joined #openmrs
11:59:19 *** nribeka_ has joined #openmrs
12:04:10 *** bmckown has joined #openmrs
12:04:10 *** ChanServ sets mode: +o bmckown
12:06:15 *** scottyaz has quit IRC
12:06:31 *** scottyaz has joined #openmrs
12:16:14 *** atomicturtle has joined #openmrs
12:16:43 *** scottyaz has quit IRC
12:16:58 *** scottyaz has joined #openmrs
12:17:01 *** nribeka has quit IRC
12:25:45 *** scottyaz_ has joined #openmrs
12:34:02 *** scottyaz has quit IRC
12:44:09 *** scottyaz_ has quit IRC
13:09:15 *** bmckown has quit IRC
13:22:55 *** SrFabio has joined #openmrs
13:24:20 <SrFabio> hi
13:25:03 <pascal`> Hi SrFabio
13:25:20 <SrFabio> ;)
13:25:54 *** bmckown has joined #openmrs
13:25:54 *** ChanServ sets mode: +o bmckown
13:34:07 *** bmckown_ has joined #openmrs
13:34:07 *** ChanServ sets mode: +o bmckown_
13:34:14 *** bmckown has quit IRC
13:34:14 *** bmckown_ is now known as bmckown
13:39:14 *** bmckown has quit IRC
13:39:15 *** bmckown_ has joined #openmrs
13:39:15 *** ChanServ sets mode: +o bmckown_
13:41:46 *** bmckown_ has quit IRC
13:51:38 *** atomicturtle has left #openmrs
14:05:27 *** bmckown has joined #openmrs
14:05:27 *** ChanServ sets mode: +o bmckown
14:08:57 <pascal`> Got connection problems bmkown?
14:10:48 <nribeka_> yeah, bmckown always have internet problem_
14:12:31 <pascal`> ic
14:16:20 <bmckown> nah. I was on iphone during staff meeting.
14:16:34 <bmckown> so was like logging in and out of irc.
14:16:34 <pascal`> ok
14:16:46 <pascal`> that i did see
14:16:49 <pascal`> hence the question
14:17:08 <bmckown> right. i thought by backgrounding the app it would keep me logged in... i guess not so.
14:17:21 <pascal`> hmm
14:17:31 <pascal`> what os version are you running?
14:17:45 <nribeka_> 3.0
14:17:46 <bmckown> I'm running ubuntu 8.10 on laptop.
14:17:51 <bmckown> and 3.0 on iphone
14:17:57 <bmckown> jailbroken 3.0
14:18:29 <pascal`> sweet
14:18:48 <pascal`> well, 9.04 would be better for the laptop (=
14:20:04 <bmckown> except AR5416 wireless driver not working yet for me on 9.04
14:20:12 <pascal`> are you using Rooms?
14:20:17 <bmckown> Rooms?
14:20:20 <bmckown> what's that?
14:20:24 <pascal`> iphone irc app
14:20:29 <pascal`> i guess not
14:20:45 <bmckown> Colloquy
14:21:31 <nribeka_> is it good bmac?
14:21:47 <nribeka_> i used to have lime irc on my prev iphone
14:22:08 <bmckown> well i haven't tried lime (i think colloquy is cheaper than lime) or any others
14:22:15 <bmckown> colloquy is good i think.
14:22:46 <pascal`> i've used jmirc
14:23:03 <pascal`> afaik it stays connected in the background, but that might be an iphone limitation
14:23:05 <nribeka_> well you can always try it from the repos :)
14:23:18 <bmckown> hmm. yes i might try that.
14:23:31 <bmckown> kind of sucks to get logged off when you background the app.
14:23:42 <nribeka_> i think the only thing that can run on bg process is the ipod apps
14:24:14 <bmckown> theres "Backgrounder" app in Cydia that allows backgrounding of apps.
14:24:21 <bmckown> such as skype, irc, or anything.
14:24:27 <bmckown> for iphone.
14:24:32 <bmckown> (jailbroken)
14:25:44 <nribeka_> eh ... really?
14:27:37 <nribeka_> in which repo is it bmac?
14:27:40 <nribeka_> i can't find it
14:27:42 <nribeka_> hahaha ...
14:28:30 <nribeka_> o another thing:
14:28:37 <bmckown> it's in the main repo... just search "backgrounder"
14:29:51 <bmckown> you may have to unfilter your repo's (as in select "developer" for sources)
14:30:09 <nribeka_> if i initialize the identifier with some values, the second identifier will be added to the patient
14:30:48 <bmckown> automatically it adds a second identifier that is empty you mean?
14:31:12 <bmckown> It's supposed to loop through all existing identifiers and display them.
14:31:19 <nribeka_> http://pastie.org/541373
14:32:17 <nribeka_> that's the equals method. since the first identifier is null (this also become null: patient, identifier, identifierType) and the ret will always true
14:32:28 <nribeka_> the return of equals always true
14:33:08 <pascal`> if patient and identifier are null, wont it always return true?
14:33:23 <nribeka_> and the collectionContains in OpenmrsUtil will always return true
14:33:35 <nribeka_> thus, no identifier will be able to go to the set :)
14:33:37 <pascal`> and identifierType
14:33:41 <nribeka_> yes pascal
14:33:47 <pascal`> oh
14:33:54 <pascal`> soz, didn't read your post before i posted
14:35:04 <nribeka_> so ...
14:35:42 <bmckown> hmm. :-)
14:42:37 <bmckown> so you're saying the code you pasted is wrong, nribeka_ ?
14:44:24 <nribeka_> i think it's assuming that the base object never null and has the correct form of patient identifier (so they can be compared)
14:44:48 <nribeka_> in the lab i init the first identifier with "Test"
14:45:06 *** sdefabbiakane has joined #openmrs
14:45:15 <bmckown> eh... okay i see
14:45:31 <bmckown> cause it should be
14:45:40 <pascal`> surely if patient or identifier is null it should return false?
14:45:59 <bmckown> if (obj instanceof PatientIdentifier && patient != null) on line 8
14:46:12 <bmckown> otherwise it returns true if patient is null.
14:46:17 <bmckown> nice catch.
14:46:38 <bmckown> looks like a ticket and a patch you can do, nribeka_ eh? that's in core, no?
14:46:46 <nribeka_> in core bmckown
14:46:57 <bmckown> looks fair enough for a ticket and patch.
14:47:08 <bmckown> i mean a ticket and fix.
14:47:12 <bmckown> (not patch)
14:47:18 <nribeka_> this probably should go to dev list for discussion? because it's core object :P
14:47:33 <bmckown> it looks like a simple fix to me.
14:47:35 <nribeka_> ok. i will create ticket and attach a patch
14:47:46 <bmckown> a patch is always safe.
14:47:47 <sdefabbiakane> anyone have any idea why the in-memory unit test db would randomly stop loading the default database schema? it's telling me it can't find the 'person'' table...
14:48:19 <bmckown> is that in a module, sdefabbiakane ?
14:48:43 <sdefabbiakane> bmckown: yeah. it was working before, no idea what changed.
14:48:44 <nribeka_> i was thinking the fix would be? boolean ret = false; instead of true
14:48:46 <nribeka_> :)
14:48:52 <bmckown> there may have been a change in the schema for person table.
14:49:24 <bmckown> maybe make sure that all required elements for person in the xml schema are initialized in the schema.
14:50:10 <pascal`> nribeka_++
14:50:13 <bmckown> yes, nribeka_ that sounds better i think. hmm. but to be sure maybe patch. not sure if there's a reason why they want to failsafe to returning true if the patient is null.
14:50:24 <bmckown> nribeka_++
14:50:29 <sdefabbiakane> bmckown: alright, thanks
14:50:33 <nribeka_> ok ok bmac :)
14:50:38 <nribeka_> patch it is ;)
14:52:28 <pascal`> nribeka, i'm not sure that just changin ret = false will do the trick
14:52:42 <pascal`> may i suggest adding the null checks at the beginning?
14:53:50 <pascal`> that way there is an early out, which could potentially speed things up... although I don't think that it will often be the case that patient or identifier are null.... but I'm not sure.
14:58:12 <bmckown> good point, pascal`
14:58:35 <pascal`> !karma
14:58:35 <OpenMRSBot> pascal`: Highest karma: "bwolfe" (50), "groovy" (31), and "burke" (13). Lowest karma: "r0bby" (-2), "scriptlets" (-1), and "emacs" (-1). You (pascal`) are ranked 5 out of 86.
14:58:50 <pascal`> lol r0bby at -2 (=
14:58:50 <bmckown> pascal`++
14:58:50 <nribeka_> since there's already a checking for the patient != null inside the if block
14:59:00 <nribeka_> block bmac ;)
14:59:06 <bmckown> hehe
14:59:14 <nribeka_> which block do you want to learn today ...
14:59:28 <pascal`> well nribeka, if you init ret to false, then you're going to have to set it true iff all the conditions are met... which will look messy imho
14:59:45 <bmckown> i once tried to kick myself off of irc just to see if it would work
15:00:16 <pascal`> that reminds me of a funny bash.org post
15:00:44 <pascal`> http://www.bash.org/?99060
15:01:05 <nribeka_> ouch ... that's not right
15:01:37 <bmckown> right
15:01:56 <nribeka_> why to do it: ret = ret && patient.equals(p.getPatient());
15:01:58 <bmckown> that's pretty funny.
15:02:04 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1628 (task created): PatientIdentifier's equals method always return true when the identifier, patient and identifierType null <http://dev.openmrs.org/ticket/1628>
15:02:14 <nribeka_> i read that one
15:02:16 <nribeka_> :P
15:02:40 <pascal`> nribeka_, that won't work if ret is initialized to false
15:02:48 <pascal`> ret will always stay false
15:02:55 <nribeka_> yes
15:03:00 <nribeka_> i just notice the &&
15:03:42 <nribeka_> haha ...
15:03:45 <nribeka_> reworking
15:04:09 <nribeka_> but checking only patient will leave the same problem for idtype and id
15:05:18 <bmckown> however, ideally every patient should have an identifier and every identifier should have an identifier type
15:06:38 <SrFabio> sorry people, can i help you? what was your objective when you wrote ret = ret && patient.equals(p.getPatient());
15:06:38 <SrFabio> ?
15:06:43 <bmckown> a patient without an identifier should not exist in the system.
15:06:49 <pascal`> yes, i think you've found a pathelogical case
15:07:07 <pascal`> anyway, I'm calling it a day, cheers ppl
15:07:14 <nribeka_> http://pastie.org/541410
15:07:20 <bmckown> that is code from core OpenMRS, SrFabio
15:07:23 <nribeka_> wouldn't something like this work?
15:07:38 <SrFabio> let me see
15:07:57 <pascal`> nrikeba_, i think it will cause an NPE
15:08:29 <nribeka_> hmm ...
15:08:30 <nribeka_> true
15:08:36 <pascal`> if patient is null, then when p.equals() is called with it then it will bomb out
15:09:02 <pascal`> you could try {} catch() {return false}, but that's hacky imho
15:09:19 <bmckown> http://dev.openmrs.org/browser/openmrs/trunk/src/api/org/openmrs/PatientIdentifier.java#L77
15:09:20 <nribeka_> in ideal case, there's shouldn't be a patient identifier without id
15:09:22 <bmckown> for reference
15:09:22 <pascal`> personally, i would leave everything the same, except do all the null checks up front
15:09:22 <OpenMRSBot> <http://ln-s.net/3VYw> (at dev.openmrs.org)
15:09:28 <sdefabbiakane> just check if patient is null first, then. and is lazy.
15:09:55 <nribeka_> haha ... check all null in front?
15:09:56 <pascal`> anyway, i'm sure this team of l337 experts can figure it out
15:09:57 <pascal`> l8rs
15:10:03 *** pascal` has quit IRC
15:10:23 <bmckown> nribeka_ is saying that the code doesn't work if the patient object is null.
15:10:24 <bmckown> but...
15:10:49 <SrFabio> i guess if so then it will return false
15:11:05 <bmckown> PatientIdentifier should not even exist in the system without a Patient for that identifier.
15:12:54 <nribeka_> else ret = false;
15:13:14 <nribeka_> yeah bmac
15:13:18 <nribeka_> bmckown,
15:13:25 <bmckown> nribeka_,
15:13:31 <bmckown> :-)_
15:14:12 <sdefabbiakane> so why not do:ret = patient != null && patient.equals(p.getPatient())
15:14:15 <sdefabbiakane> ?
15:15:37 <nribeka_> hmm ... that's a good idea sdefabbiakane
15:16:51 *** atomicturtle has joined #openmrs
15:17:04 <SrFabio> why dont you create an exists() method, then ret = patient.exists() ? true,false;
15:17:15 *** atomicturtle has left #openmrs
15:17:16 <SrFabio> i guess it can be useful for other purposes too
15:17:41 <SrFabio> ret = patient.exists() ? true : false; //correct now
15:22:23 <sdefabbiakane> before I go and make a long/detailed listserv post...noone has any idea why parent/child relationships in my module would work fine in the HSQL unit-testing database, but not at all in the MySQL database, do they?
15:22:37 <nribeka_> hmm ... it will be messing around with core SrFabio
15:22:59 <SrFabio> i see
15:23:08 <nribeka_> post it to the list sdefabbiakane
15:23:10 <nribeka_> :)
15:23:20 <sdefabbiakane> nribeka_: yeah, thought so =/
15:23:52 *** ChanServ sets mode: +v nribeka_
15:23:57 *** nribeka_ is now known as nribeka
15:33:18 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9037]: -- atd * added flushing to output streams before closing <http://dev.openmrs.org/changeset/9037>
15:55:31 *** SrFabio has quit IRC
16:01:53 *** sdefabbiakane has quit IRC
16:04:04 <r0bby> nribeka: if(p == null) return false;
16:04:13 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9038]: -- chica * added flushing to all output streams * fixed a javascript bug … <http://dev.openmrs.org/changeset/9038>
16:04:22 <r0bby> (How i'd do it nribeka q
16:04:35 <r0bby> I'd check null before anything else i do
16:49:51 <nribeka> r0bby, checking all of them for null first?
16:50:07 <r0bby> yes
16:50:23 <r0bby> and throwing IllegalArgumentException if they're null (if you're passing these in)
16:51:05 <r0bby> but yeh sam's solution is more elegent
16:51:08 <r0bby> you should do that
16:52:37 <nribeka> yeah i thought so
16:52:56 <r0bby> if(p == null) return false;
16:53:12 <r0bby> then everything after that is guaranteed to pass and be non-null
16:53:27 <r0bby> (assuming no other reference variables are passed)
16:55:12 <r0bby> i get the luxury of IDEA generating equals() and hashCode() for me :)
16:55:41 <nribeka> haha ... that's good :P
16:57:17 *** sdefabbiakane has joined #openmrs
16:57:23 *** sdefabbiakane has left #openmrs
16:59:47 <r0bby> nribeka: we have a license
17:02:02 <nribeka> yeps
17:02:09 <nribeka> i know that :)
17:02:19 <nribeka> it's going to expire on this coming august
17:03:15 <r0bby> we're getting it renewed
17:03:37 <r0bby> brian and I both use it =)
17:03:56 <r0bby> and if i had to use eclipse it'd be a *HUGE* learning curve plus cut in productivity :)
17:07:21 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9039]: -- logic_branch * fixed bug in hibernate criteria in … <http://dev.openmrs.org/changeset/9039>
17:07:30 <nribeka> auto renew r0bby?
17:18:16 <r0bby> nribeka: no we have to request
17:18:39 <r0bby> but likely they'll re-evaluate
17:20:53 <nribeka> ah ic ic
17:21:23 <nribeka> i have idea on my machine too. i like use them if i need to go through jsp :P
17:29:16 <r0bby> nribeka: it's a good IDE
17:29:25 <r0bby> just DO NOT use it with the new G1 garbage collector
17:29:33 <r0bby> it will crash quite frequently
17:29:38 <nribeka> G1?
17:29:54 <r0bby> the new garbage collector that came with java 6 update 14
17:30:19 * r0bby dances
17:30:23 <r0bby> I think i got it
17:30:23 <r0bby> :D
18:11:27 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9041]: ncd: Fixed the code system list page to not link code systems to the … <http://dev.openmrs.org/changeset/9041> || OpenMRS Changesets: Changeset [9040]: ncd: Added lots more logging to NlpTextAnalyzer. <http://dev.openmrs.org/changeset/9040>
18:14:30 *** jmiranda has quit IRC
18:15:44 *** atomicturtle1 has joined #openmrs
18:27:49 *** jmiranda has joined #openmrs
18:27:49 *** ChanServ sets mode: +o jmiranda
19:07:03 <r0bby> this is hot
19:07:04 <r0bby> http://kartik-shah.blogspot.com/2009/07/groovy-ast-transformation-aop-style.html
19:07:06 <OpenMRSBot> <http://ln-s.net/3VeM> (at kartik-shah.blogspot.com)
19:07:18 <r0bby> Guillaume LaForge tweeted it
19:07:27 <r0bby> well he re-tweeted it if you wanna be exact
19:08:27 <r0bby> twitter is an awesome example of non-scalability
19:08:39 <r0bby> un-
19:08:41 <r0bby> whatver
19:15:36 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9043]: facility data: also commit these. <http://dev.openmrs.org/changeset/9043> || OpenMRS Changesets: Changeset [9042]: facility data: loading of entered values *SORT OF* works; still need to … <http://dev.openmrs.org/changeset/9042>
19:15:41 <nribeka> ugh there's a method to do safe comparison
19:15:43 <nribeka> nullSafeEquals
19:21:56 <r0bby> nribeka: eh i still do it :)
19:22:06 <r0bby> im lazy :)
19:22:23 <r0bby> it's second nature -- trained to program defensively :)
19:22:36 <r0bby> anticipate disaster before it happens :)
19:23:16 <nribeka> :)
19:24:05 <r0bby> yeh i dont like that method
19:24:59 <r0bby> you should never pass null into equals() and if you do, it should always return false :)
19:25:24 <r0bby> in other methods i throw illegalargumentexception
19:25:52 <r0bby> just how i roll :)
20:19:38 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [9046]: ncd: Added more logging to the NlpContextChecker. <http://dev.openmrs.org/changeset/9046> || OpenMRS Changesets: Changeset [9045]: amrs registration: refactor controller to add handler for "add new" button <http://dev.openmrs.org/changeset/9045> || OpenMRS Changesets: Changeset [9044]: ncd: Added original critic name to the classifiedByWhom field of the … <http://dev.openmrs.org/changeset/9044>
21:06:10 *** atomicturtle1 has left #openmrs
21:19:25 *** bmckown has quit IRC
21:37:27 *** nribeka has quit IRC
22:46:31 *** nribeka has joined #openmrs
22:46:31 *** ChanServ sets mode: +v nribeka
22:47:01 *** nribeka_ has joined #openmrs
23:11:18 *** nribeka has quit IRC
  • No labels