Wiki Spaces

Documentation
Projects
Resources

Get Help from Others

Q&A: Ask OpenMRS »
Discussion: OpenMRS Talk »
Real-Time: IRC Chat

IRC Logs

Child pages
  • 2009-03-16 - OpenMRS
Skip to end of metadata
Go to start of metadata
00:00:05 <r0bby> I think i got an idea
00:01:39 <r0bby> I can always come up w/ a summer of code project a different one
00:01:45 <r0bby> I'm sure there are extensionsto whatever i do :)
00:02:17 <Keelhaul> yea but do you have time to do two projects
00:02:28 <Keelhaul> http://www.escapistmagazine.com/news/view/90176-iPod-Explodes-Melts-Kids-Underwear
00:02:31 <OpenMRSBot> <http://ln-s.net/311s> (at www.escapistmagazine.com)
00:02:39 <r0bby> I'm pushing groovyforms to the back burner
00:02:57 <r0bby> the code i write here can be ported to that
00:03:03 <r0bby> It's still active
00:03:11 <bwolfe> r0bby: work done before gsoc starts does not count for gsoc money...so you'd have to put in more time over the summer
00:03:33 <r0bby> we could work on that
00:03:41 <r0bby> I'm sure I could do that :)
00:03:54 <r0bby> I'm gonna claim this I have the wiki page done I plopped it under groovy forms
00:03:58 <bwolfe> r0bby: the wysiwyg project should be more about writing widgets for "concept search" into something like FCKeditor and less about which controller you use
00:04:17 <r0bby> bwolfe: i made it two-fold
00:04:18 <bwolfe> r0bby: it will be replacing the large textboxes that htmlformentry uses right now
00:04:25 <r0bby> I added Groovy Scripting to it
00:04:54 <bwolfe> r0bby: I like the idea of groovy scripting being a whole different project
00:05:09 <r0bby> Then I will claim that as well ;x Bad idea?
00:05:20 <bwolfe> r0bby: seriously, plan small
00:05:32 <bwolfe> r0bby: thats partly what got you into trouble in the first place
00:06:29 <r0bby> I'll throw groovy scripting up and put myself as the mentor (since i seem to be the only developer aside from burke who knows groovy ;x)
00:06:34 <r0bby> bad idea?
00:06:47 <r0bby> never mind on that
00:07:36 <r0bby> I don't anticipate this taking me too long :x
00:08:31 <bwolfe> r0bby: which one isn't going to take too long ?
00:08:47 <r0bby> Wysiwyg editor
00:09:03 <bwolfe> r0bby: then do it this week, apply for gsoc for the 'adding groovy scripting to htmlformentry' project. :-)
00:10:48 <bwolfe> r0bby: and fyi, you can't be a mentor and a student in the same year
00:10:57 <bwolfe> r0bby: so you're going to have to choose now, mentor or student ?
00:12:31 <r0bby> i can't mentor
00:12:41 <r0bby> burke/paul both think i need to prove leadership first
00:14:34 <r0bby> I added it to the project page
00:15:14 <r0bby> may wanna tweak the Abstract
00:15:58 <r0bby> bwolfe: who would mentor this?
00:17:19 <r0bby> I put it up in the air
00:17:58 <r0bby> http://openmrs.org/wiki/Projects#Add_.5Bhttp:.2F.2Fgroovy.codehaus.org_Groovy_Scripting.5D_to_.5B.5BHtml_Form_Entry_Module.5D.5D
00:18:00 <OpenMRSBot> <http://ln-s.net/3121> (at openmrs.org)
00:18:26 <r0bby> there is a curve to the mentor if he/she does not know groovy
00:18:52 <r0bby> the guts of what needs to happen is already in groovyforms
00:19:00 <Keelhaul> that means only burke could =)
00:20:07 <r0bby> burke cannot
00:20:16 <r0bby> which means i need to mentor
00:20:24 <r0bby> but i can't
00:20:31 <r0bby> I won't get voted in
00:20:50 <Keelhaul> then you should come up with something that doesnt include groovy i guess
00:28:43 <r0bby> fired off an email to darius
00:30:00 <r0bby> :)
00:35:25 <Keelhaul> i need a new set of batteries for my mouse
00:35:36 <Keelhaul> i have to recharge them more often now
00:35:40 * r0bby humps his touchpad
00:35:45 <r0bby> I could call Darius
00:35:51 <r0bby> but I won't i don't wanna bother him.
00:36:52 <Keelhaul> maybe not on a sunday evening =)
00:38:04 <r0bby> yeh
00:38:15 <r0bby> I'll catch him in the A.M.
00:38:26 <r0bby> right now time to go learn how to use FCKEditor
00:39:56 <r0bby> I hope i'm not making a mistake putting groovy forms on the back burner
00:40:18 <r0bby> for something that I know is more pressing
00:46:55 <r0bby> I can't wait the ivy project to go through
00:47:02 <r0bby> ivy can do maven repos :)
00:49:02 * r0bby goes to learn
00:52:31 <Keelhaul> adding new functions to two branches of the same module is tedious =/
00:54:30 * r0bby is excited
00:55:16 <Keelhaul> less excitement more reading!
01:06:16 * r0bby reads
01:06:35 <r0bby> Yes mom, i shall read :)
01:14:14 *** nribeka has joined #openmrs
01:15:21 *** atomicturtle has joined #openmrs
01:15:29 *** atomicturtle has left #openmrs
01:21:31 <r0bby> Ugh I wanna do the servlets and controllers in groovy not java :(
01:37:19 * r0bby waits for darius :)
01:43:45 * r0bby dances
01:48:24 <r0bby> I think this is scoped small enough to manage
02:16:13 *** isurundt has joined #openmrs
02:17:28 <isurundt> hi ben. I added a new patch to EncounterType class. did u have a look at that
02:18:30 <Keelhaul> they usually only review code when the whole thing is finished
02:19:30 <r0bby> isurundt: =)
02:20:56 <isurundt> robby: ohh.. :)
02:22:11 <isurundt> didn't know that earlier. :)
02:40:26 *** upul has joined #openmrs
02:41:46 <bwolfe> isurundt / Keelhaul : we can do quick reviews whenever. all you have to do is ask
02:41:57 <bwolfe> but yes, the formal reviews only come at the end
02:42:08 <bwolfe> r0bby: the controllers should be in java
02:42:21 <Keelhaul> bwolfe: my extensionpoint in the user form doesnt work =/
02:42:32 <bwolfe> r0bby: check out the patientnotewriter module from last year. I think he integrated fckeditor into his
02:43:05 <bwolfe> Keelhaul: extension points aren't that complicated...how is it not working? did you match the text in your config.xml and the user.form extensionPoint ?
02:43:28 <Keelhaul> yes
02:43:34 <Keelhaul> i've added lots of extensions before
02:43:35 <Keelhaul> heh
02:48:06 <Keelhaul> bwolfe: http://rafb.net/p/NHALY179.html
02:48:09 <Keelhaul> this should be all
02:51:20 <bwolfe> unless the portlet url needs to have your module id in it somewhere
02:51:23 <bwolfe> I can't remember
02:51:37 <bwolfe> but if you're just returning a link like that, you don't need a PortletExt
02:51:56 <Keelhaul> oh hmm
02:51:57 <bwolfe> just use a normal Ext and return the string from the getBodyContent(String) method
02:51:58 <Keelhaul> true
02:52:01 <Keelhaul> all i have is a link
02:52:23 <Keelhaul> i havent done this in a while, i copied the way i did another extension
02:52:25 <Keelhaul> which works btw
02:52:26 <Keelhaul> lol
03:13:44 <Keelhaul> bwolfe: the actual extension point is all i have to define on the host page, right?
03:13:47 <Keelhaul> no imports or anything
03:21:03 *** bwolfe has quit IRC
04:28:17 * r0bby sighs
04:28:27 <r0bby> yeh forgot to consult darius
04:29:22 <r0bby> jesus i'm making faux pas left and right lately :(
04:29:24 <r0bby> :-/
05:50:27 <r0bby> wow
05:50:39 <r0bby> there is a scary lack of testing in all modules
05:50:44 <r0bby> a lot of them have poor coverage
05:50:47 <r0bby> ie 0%
05:52:46 <r0bby> :/
05:52:53 <r0bby> some test decently, others don't test at all
06:12:24 *** Keelhaul has quit IRC
09:41:49 *** isurundt has left #openmrs
09:41:59 *** isurundt has joined #openmrs
11:29:28 *** james_regen has joined #openmrs
11:29:28 *** ChanServ sets mode: +v james_regen
12:02:34 *** isurundt has quit IRC
12:41:55 *** bwolfe has joined #openmrs
12:41:55 *** ChanServ sets mode: +o bwolfe
12:45:19 *** upul has quit IRC
13:47:33 *** Keelhaul has joined #openmrs
13:47:33 *** ChanServ sets mode: +v Keelhaul
13:48:53 <Keelhaul> bwolfe: ConceptNumeric.absolute=Absolute
13:48:56 <Keelhaul> should this go as well?
13:48:58 <Keelhaul> or stay
13:49:24 <bwolfe> Keelhaul: do a global search to see if its used anywhere
13:49:33 <bwolfe> but my guess is that it is not, and so it could go too
13:49:36 <Keelhaul> ctrl-h?
13:51:32 <Keelhaul> bwolfe: nope, it were actually just concept and conceptform
13:51:43 <Keelhaul> but there are spanish and italian translations
13:51:53 <Keelhaul> not sure i can translate those correctly heh
13:53:05 <Keelhaul> absoluto basso lol
13:53:19 <Keelhaul> er
13:53:20 <Keelhaul> assoluto
13:53:22 <bwolfe> Keelhaul: for those you can probably combine them...spanish/italian are similar enough to english
13:59:30 <Keelhaul> ConceptNumeric.absolute.msg=Value within absolute absolute numeric range
13:59:36 <Keelhaul> is this a mistake?
14:05:32 <bwolfe> is that used at all Keelhaul ?
14:05:38 <bwolfe> perhaps it is the "help" text
14:05:41 <Keelhaul> no idea
14:05:45 <Keelhaul> yea, sounds like that
14:05:57 <Keelhaul> but it looks like something that would be used on some obs page
14:05:59 <Keelhaul> dunno
14:06:03 <Keelhaul> i havent seen it anywhere
14:07:36 <bwolfe> cntrl-h
14:07:37 <bwolfe> :-)
14:08:38 <Keelhaul> bwolfe: does file search automaticall include wildcards?
14:08:44 <Keelhaul> if i say numeric.critical
14:08:47 <Keelhaul> etc
14:09:32 <bwolfe> that would match to numeric.critical.low, yes
14:09:43 <Keelhaul> ok
14:09:49 <Keelhaul> then i already search for those
14:09:52 <Keelhaul> and they arent used
14:09:56 <Keelhaul> should i still leave them in?
14:11:07 <bwolfe> you can take them out too
14:11:15 <bwolfe> or fix them and them use them. :-)
14:15:11 <Keelhaul> nah =P
14:15:16 <Keelhaul> no time =/
14:15:39 <Keelhaul> didnt even get around to finish my messages_de.properties file
14:15:44 <Keelhaul> not that anyone really needs it
14:15:46 <Keelhaul> but i was about 1/3 done
14:24:00 <bwolfe> Keelhaul: can you attach what you have to that ticket I just made ?
14:24:07 <bwolfe> that way your work doesn't get lost somewhere
14:24:10 <bwolfe> or somehow
14:25:38 <Keelhaul> what ticket =o
14:25:57 <Keelhaul> oh you mean translation
14:26:06 <Keelhaul> i just updated my ranges patch
14:27:07 <Keelhaul> bwolfe: maybe it should be a ticket about adding more languages in general
14:27:46 <bwolfe> Keelhaul: perhaps we need one like that
14:27:58 <bwolfe> Keelhaul: but for now, since you have some work on the german one, it should be separate
14:28:10 *** upul has joined #openmrs
14:28:14 <bwolfe> (also, I dislike "long running" tickets like "add translation files") :-)
14:28:18 <Keelhaul> heh
14:28:30 <Keelhaul> i'd rather have long running tickets than a larger number of them =P
14:31:40 *** upul has quit IRC
14:31:53 *** upul has joined #openmrs
14:48:23 *** k_nishant has joined #openmrs
14:49:44 <Keelhaul> . (class\=Question should typically not be datatype\=N/A.)
14:49:47 <Keelhaul> bwolfe, what is this
14:50:04 <bwolfe> a warning darius put in for the concept dictionary
14:51:03 *** bmckown has joined #openmrs
14:51:03 *** ChanServ sets mode: +o bmckown
14:52:01 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1334 (enhancement created): Create a German messages.properties translation file <http://dev.openmrs.org/ticket/1334> || OpenMRS Tickets: Ticket #1314 (task closed): Change tinyint and bit columns to tinyint(1) <http://dev.openmrs.org/ticket/1314#comment:4> || OpenMRS Changesets: Changeset [7121]: Switched all boolean columns to the sql standard smallint to standardize … <http://dev.openmrs.org/changeset/7121>
14:52:10 <Keelhaul> is that some script code
14:52:12 <Keelhaul> or just text
15:02:11 *** k_nishant has quit IRC
15:10:05 *** bwolfe_ has joined #openmrs
15:10:05 *** ChanServ sets mode: +o bwolfe_
15:18:27 *** bwolfe has quit IRC
15:24:05 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7122]: Fixed bogus project name <http://dev.openmrs.org/changeset/7122>
15:26:08 *** Nzeyi has joined #openmrs
15:32:11 *** atomicturtle has joined #openmrs
15:32:52 *** atomicturtle has left #openmrs
15:48:33 *** Nzeyi has quit IRC
16:08:47 *** upul has quit IRC
16:24:15 *** bwolfe__ has joined #openmrs
16:25:36 *** bwolfe__ is now known as bwolfe
16:30:47 *** nribeka has quit IRC
16:37:06 <Keelhaul> hey bmckown, have you seen the patch i added to your ticket about auto-populating privilege boxes?
16:40:52 *** bwolfe_ has quit IRC
16:40:57 <bmckown> Hi, Keelhaul ... well I /saw/ it but haven't had the moment to really look at it. :-D Let me do so today and I'll comment on the ticket. Um... did you do that in openmrs 1.5?
16:42:51 <Keelhaul> bmckown: lets say i want it in trunk asap, because i need that in my own war file, and my trunk is butchered enough as is =)
16:43:49 <Keelhaul> oh damn
16:43:54 <Keelhaul> i should read questions more carefully
16:43:59 <Keelhaul> yea, i did it in trunk
16:44:29 <Keelhaul> although i doubt anything in those files has changed since 1.4
16:44:33 <Keelhaul> or 1.3 even
16:44:43 <bmckown> okay. I'll have to create an openmrs 1.5 database on my laptop then. last time i ran trunk on my laptop it irreversably messed up my database.
16:45:08 <Keelhaul> heh
16:48:30 *** isurundt has joined #openmrs
16:53:46 *** nribeka has joined #openmrs
17:04:18 <isurundt> bwolfe:what is the way to unassign a task which has assigned to me?
17:06:01 <bwolfe> bmckown: the easiest way to create a 1.5 database is to use the wizard. just rename your runtime properties file to something else and restart openmrs
17:06:25 <bmckown> okay
17:06:38 <bwolfe> isurundt: by changing the ticket to be assigned to "" and fixing the projects.openmrs.org page to put the Encounter Type Hierarchy in the "to be assigned" instead of the "assigned" section
17:06:54 <bmckown> (he must hear me grumbling over the cubicle wall) hehe
17:09:57 <nribeka> hi bwolfe
17:10:44 <bwolfe> hey nribeka, its been a while :-)
17:10:45 <Keelhaul> isurundt: are you done or dont want to do it?
17:12:18 <nribeka> haha yeah :D
17:12:27 *** Echidna has quit IRC
17:12:37 <nribeka> got some int over last week
17:13:19 <bmckown> Should I assume that a new openmrs 1.5 with no runtime properties does not like having an existing openmrs database around?
17:13:58 <Keelhaul> well
17:14:02 <Keelhaul> i think so
17:14:03 <isurundt> keelhaul: need to do that. like to apply that for gsoc. So i thought of keeping it open for others to apply. :)
17:14:19 <Keelhaul> isurundt: how thoughtful of you =P
17:14:29 <isurundt> :)
17:14:43 <Keelhaul> bmckown: i forgot to copy the runtime props over once, i got exceptions on every page except the wizard
17:15:03 <bwolfe> bmckown: if you specify an existing database in the wizard that db will be upgraded. if you specify a new database in the wizard, one will be created and a populated/updated
17:15:50 <bwolfe> bmckown: 1.5 will create the runtimeproperties file for you. but in order for the wizard to be triggered (so that you can create a new database easily), openmrs can't find a runtime props file
17:16:01 <bwolfe> (because if it finds a runtime props file it just starts up)
17:16:14 <bmckown> hmm. okay. so I should actually get the wizard. http://pastebin.com/m44b10ec6
17:16:25 <bmckown> I /thought/ i removed all runtime properies files.
17:16:39 <bmckown> or "moved" them out of the way.
17:17:00 <nribeka> bwolfe, question
17:17:04 <Keelhaul> can patches form trunk be applied to other project names?
17:17:22 <Keelhaul> i'm not sure all the trouble deploying 1.5 is really necessary
17:17:45 *** Echidna has joined #openmrs
17:17:57 <bwolfe> bmckown: hmm, I think Keelhaul had that error at some point
17:18:09 <bwolfe> or someone did, because it looks familiar...but I don't know why that happens
17:18:14 <nribeka> in the utils to for the password regex, would you prefer the method to return boolean true (whether the password string is accepted or not) or string (for error message about the password string)
17:18:39 <bwolfe> Keelhaul: yes, you can apply patches from any project to any other project (1.4 to trunk, trunk to a tag, etc)
17:18:42 <nribeka> s/to for/for
17:19:10 <bwolfe> nribeka: what are you naming the method ?
17:21:13 <nribeka> if boolean then isPasswordAccepted
17:23:37 *** openmrs_2134 has joined #openmrs
17:23:47 *** openmrs_2134 has quit IRC
17:23:51 <bwolfe> nribeka: how about void validatePassword(String username, String password) throws PasswordException; and have a few different types of PasswordExceptions: WeakPasswordException, MatchesUsernamePasswordException, ShortPasswordException
17:26:28 <nribeka> hmmm interesting :D
17:29:47 *** Keelhaul has quit IRC
17:29:56 *** Keelhaul|afk has joined #openmrs
17:41:21 *** bmckown has quit IRC
17:49:22 *** isurundt has quit IRC
18:27:34 *** Keelhaul|afk has quit IRC
18:27:39 *** Keelhaul has joined #openmrs
18:27:39 *** ChanServ sets mode: +v Keelhaul
18:31:23 *** isurundt has joined #openmrs
18:55:04 *** isurundt has quit IRC
18:56:40 <nribeka> bwolfe, i have a question :D
18:56:51 <bwolfe> yessir
18:59:09 <nribeka> hehe ...
18:59:20 <nribeka> what does this means?
18:59:22 <nribeka> if (confirm == null || confirm.equals("XXXXXXXXXXXXXXX"))
18:59:31 <nribeka> user form controller
18:59:33 <nribeka> line 112
19:00:06 <bwolfe> nribeka: the password field has XXXXXXXXXXXX put into it by default instead of the user's actual password
19:00:26 <bwolfe> so when they submit the form and don't change anything, the confirm and password fields will be "XXXXXXXXXXXXXXXXXXXX"
19:03:38 <nribeka> ooo ic ic :D
19:41:16 *** k_nishant has joined #openmrs
19:51:52 <nribeka> bwolfe
19:51:55 <nribeka> http://pastebin.com/m7657dbfe
19:51:56 <nribeka> ?
19:52:01 <nribeka> comments?
19:52:25 <nribeka> at OpenmrsUtil
19:56:56 <nribeka> chunk of the test
19:56:58 <nribeka> http://pastebin.com/mfea402e
19:57:07 <nribeka> looks funny with lots of try and catch
19:57:27 <Keelhaul> dont be too strict with passwords =/
19:58:24 <nribeka> Keelhaul: hehe :D
19:58:46 <nribeka> minimal one upper case and digit char :P
19:58:51 <nribeka> 8 char min
20:01:59 <bwolfe> nribeka: the tests can simply be: http://pastebin.com/m49ba4e8a
20:05:59 *** k_nishant has quit IRC
20:06:03 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [7124]: chica: added check for correct privileges on displaytiff and viewEncounter … <http://dev.openmrs.org/changeset/7124> || OpenMRS Changesets: Changeset [7123]: openmrs-logic:Merging trunk into branch [7078]:[7122] <http://dev.openmrs.org/changeset/7123>
20:07:17 <nribeka> bwolfe, that's cool. expected
20:08:58 <bwolfe> ah yes, sorry
20:09:10 <nribeka> so, i will need to create each test for each case?
20:09:12 <bwolfe> it removes 3 lines of code. less code is always nice :-)
20:09:17 <bwolfe> nribeka: yeah, probably
20:09:21 <nribeka> lol
20:09:22 <nribeka> ok :D
20:10:45 <Keelhaul> nribeka: i hate that =/
20:10:49 <Keelhaul> always a bitch to type in
20:11:25 <Keelhaul> the windows server 2008 that i installed on Echidna requires at least one special character in the password too
20:12:35 <nribeka> but (hopefully) it will be more secure
20:13:08 <bwolfe> Keelhaul: for a patient data repository, the password should probably be more strict
20:13:17 <Keelhaul> probably
20:13:32 <Keelhaul> i'm just glad i dont have to comply while developing =)
20:13:42 <Keelhaul> copy&paste in mysql =)
20:14:23 <Keelhaul> what's "salt" for btw
20:15:12 <bwolfe> its some random characters added to the password to make reverse cracking 100x harder
20:15:19 <nribeka> haha
20:16:20 <bwolfe> whoa, eclipse can do a "three-way compare"
20:16:29 <bwolfe> wonder why people would ever need that...
20:19:34 *** james_regen has quit IRC
20:20:52 <Keelhaul> bbl
20:20:54 *** Keelhaul has quit IRC
20:24:07 <nribeka> bwolfe, http://pastebin.com/m64a533bd
20:24:59 <r0bby> bwolfe: ping
20:25:41 <bwolfe> nribeka: looks about 90% right
20:25:56 <bwolfe> nribeka: you should learn to love our eclipse junit test plugin
20:26:12 <nribeka> r0bby, last night i already slept when you send message :P
20:26:14 <bwolfe> it will generate the methods for you in the format that works with the "@should" annotations
20:26:23 <r0bby> I'm hosed
20:26:24 <r0bby> :|
20:26:30 <r0bby> I use IntelliJ IDEA :|
20:26:39 <nribeka> bwolfe, how to use it?
20:26:40 <nribeka> :D
20:26:45 <bwolfe> r0bby: you can write an idea plugin
20:26:47 <bwolfe> hmm
20:26:49 <bwolfe> !@should
20:26:49 <OpenMRSBot> bwolfe: Error: "@should" is not a valid command.
20:27:05 <r0bby> I have groovyforms to do :P
20:27:26 <bwolfe> !learn @should as http://openmrs.org/wiki/Unit_Testing_with_%40should
20:27:26 <OpenMRSBot> bwolfe: The operation succeeded.
20:28:48 <bwolfe> r0bby: you pang?
20:28:57 <r0bby> yeh
20:29:14 <r0bby> Any examples lurking around bout testing spring controllers in modules?
20:33:02 <r0bby> such that i can pull in the app context
20:35:19 <r0bby> :x
20:39:30 <bwolfe> r0bby: what is it that you need to do ?
20:39:37 <bwolfe> !testing
20:39:37 <OpenMRSBot> bwolfe: Error: "testing" is not a valid command.
20:40:05 <bwolfe> !learn moduletesting as http://openmrs.org/wiki/Module_Unit_Testing
20:40:05 <OpenMRSBot> bwolfe: The operation succeeded.
20:40:14 <bwolfe> !learn testing as http://openmrs.org/wiki/Testing
20:40:14 <OpenMRSBot> bwolfe: The operation succeeded.
20:40:24 <bwolfe> !refer r0bby [moduletesting]
20:40:24 * OpenMRSBot refers r0bby to "moduletesting" --- http://openmrs.org/wiki/Module_Unit_Testing
20:41:33 <r0bby> test a spring mvc controller
20:41:50 <r0bby> that's what
20:42:00 <r0bby> I've avoided using dbs :-)
20:42:26 <r0bby> that doesn't even remotely answer my question
20:42:50 <bwolfe> thats how you set up module tests
20:43:02 <bwolfe> if set up that way, your module's app context is pulled in
20:43:11 <r0bby> ah ok.
20:43:57 <r0bby> :)
20:44:16 <r0bby> so it'd work for spring controllers?
20:45:51 * r0bby is still following TDD :X
20:46:49 <r0bby> I still have no clue how to set the request parameters etc
20:46:58 * r0bby pulls out his Spring MVC book
20:47:13 <r0bby> it's not writing the test that's the problem
20:47:17 <r0bby> it's the whole testing bit
20:47:27 * r0bby looks up in trunk nevermind forget it
20:53:56 <nribeka> wow the plugin is neat bwolfe
20:54:04 <nribeka> you wrote this one too?
20:54:05 <nribeka> cool
20:54:06 <nribeka> :D
20:54:12 <r0bby> :) I got it
20:54:17 <r0bby> sorr for being so snippy
20:54:22 <bwolfe> nribeka: no, we had someone else do it
20:59:18 <r0bby> oh this is cute
20:59:19 <r0bby> Exception in thread "main" java.lang.NoSuchMethodError: org.junit.runner.notification.RunNotifier.testAborted(Lorg/unit/unner/escription;Ljava/ang/hrowable;)V
21:00:52 <r0bby> so to doOHH
21:00:53 <r0bby> ok
21:00:56 <r0bby> i think i get it now
21:01:07 <r0bby> The bindings i specificed in <spring:bind is what i put for the request params
21:05:55 <r0bby> ohh ben
21:06:04 <r0bby> Saturday I chickened out singing Madonna Like a virgin
21:06:17 <r0bby> and this is logged and I just admitted to that
21:07:18 <bwolfe> nice
21:07:34 <bwolfe> karaoke ?
21:08:46 <r0bby> yes
21:08:51 <r0bby> I got booed
21:08:56 <r0bby> I ALMOST did I feel pretty
21:53:20 *** nribeka has quit IRC
21:57:17 <r0bby> bwolfe: I think video of the epic fail will be on youtube if my friends have anything to say about it
21:57:28 <r0bby> they're super pissed about me chickening out
21:57:29 <r0bby> :x
22:15:00 *** Echidna has quit IRC
22:15:14 *** Echidna has joined #openmrs
22:16:32 * r0bby is slowly getting how spring MVC controllers work
22:19:06 <r0bby> bwolfe
22:19:10 <r0bby> what the heck: if (oldIdentifier && 1 == 0) {
22:20:48 *** nribeka has joined #openmrs
22:22:01 <r0bby> nribeka: am I missing something here
22:22:03 <r0bby> if (oldIdentifier && 1 == 0) {
22:22:05 <r0bby> lol
22:22:22 <nribeka> :P
22:22:37 <r0bby> in admin/newPatientForm.jsp
22:22:41 <r0bby> in openmrs trunk
22:22:54 <r0bby> I looked at that and was like uhm... what?
22:23:17 <nribeka> really?
22:23:31 <nribeka> lemme check
22:24:02 <nribeka> hmm
22:24:06 <nribeka> i see it
22:24:28 <nribeka> what is it for then?
22:24:31 <nribeka> hehe
22:25:03 <nribeka> prob i == 0?
22:26:43 *** bwolfe has quit IRC
22:31:32 <r0bby> 1 == 0
22:32:06 <r0bby> Chase put it in
22:37:51 <r0bby> I'm just curious...
  • No labels