Wiki Spaces


Get Help from Others

Q&A: Ask OpenMRS »
Discussion: OpenMRS Talk »
Real-Time: IRC Chat

IRC Logs

Child pages
  • 2009-02-23 - OpenMRS
Skip to end of metadata
Go to start of metadata
00:27:56 <Keelhaul> hey bwolfe, do you remember which modules can generate a pdf?
00:43:03 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1285 (enhancement created): The idea of Form Entry needs to be in core <>
01:05:31 <bwolfe> r0bby_: nice
01:05:37 <bwolfe> Keelhaul: clinicalsummary
01:06:00 <Keelhaul> thx
01:08:31 <r0bby_> do you have any clue how it works
01:08:43 <r0bby_> setAsText doesn't expose anything -- the variable is local to the method
01:08:58 <r0bby_> :-/
01:10:32 <r0bby_> I dont understand it :(
01:12:53 <r0bby_> :(
01:14:57 <bwolfe> r0bby_: I haven't looked at htmlformentry, so I don't know how it works either :-/
01:18:25 <r0bby_> the property editors
01:18:41 <r0bby_> it uses the openmrs ConceptEditor, LocationEditor, etc
01:18:52 <r0bby_> I like the way he went about it
01:18:57 <r0bby_> it beats what I have
01:19:03 <r0bby_> hands down since it you know, WORKS!
01:19:40 <Keelhaul> bwolfe: when are you going to review the updated location patch?
01:20:06 <bwolfe> Keelhaul: hmm, soon hopefully :-)
01:25:18 <r0bby_> Keelhaul: ask again in 10 years
01:25:22 * r0bby_ snickers
01:25:32 * r0bby_ goes back to writing this proof or disproof
01:26:01 <Keelhaul> zingue
01:27:25 <Keelhaul> bwolfe: how about putting i-text into trunk? =P
01:27:33 <Keelhaul> it's a whole meg =/
01:28:24 <r0bby_> ...why
01:29:05 <bwolfe> Keelhaul: isn't it there already ?
01:29:13 <Keelhaul> i dont think so
01:29:19 <bwolfe> Keelhaul: I think its in the /nealreporting one
01:29:22 <bwolfe> or /report
01:29:23 <bwolfe> or something
01:29:29 <bwolfe> /lib/report
01:30:04 <Keelhaul> /neal-reporting
01:30:09 <Keelhaul> hm
01:30:37 <Keelhaul> thx
01:30:46 <Keelhaul> who's neal
01:30:57 <Keelhaul> and can i rely on the jar to stay there for long
01:48:02 <bwolfe> Keelhaul: probably not. :-p as soon as the nealreporting hack is pulled out it will probably be too
01:48:24 <bwolfe> Keelhaul: does it have to be in core? or will it work in putting it in /lib in your module ?
01:48:35 <Keelhaul> yes it will
01:48:41 <Keelhaul> it will also expand the jar by 1mb lol
01:48:52 <Keelhaul> trying to keep the clutter in other people's basement =P
01:56:54 <Keelhaul> bwolfe: i forgot, what am i not supposed to do when catching exceptions in openmrs?
01:56:59 <Keelhaul> so that the stack doesnt get lost
02:02:16 <r0bby_> Keelhaul: keep the clutter in your own god damn basement
02:05:54 <bwolfe> Keelhaul: not sure what you're referring to
02:06:10 <bwolfe> Keelhaul: as long as you don't catch it and don't "throw(e)" it on
02:06:23 <Keelhaul> bwolfe: i remember reading something on a wiki page
02:06:37 <Keelhaul> i have to catch this exception
02:06:43 <Keelhaul> can i leave the catch block blank?
02:20:56 <bwolfe> Keelhaul: that is how you keep it from getting recorded
02:21:20 <bwolfe> you can put a log.debug("this happened because something went wrong", e); or a log.warn("this...", e)
02:21:34 <Keelhaul> what if i want to show it on the page
02:22:47 <bwolfe> Keelhaul: just throw it
02:22:49 <bwolfe> or don't catch it
02:23:03 <bwolfe> put a "throws Exception" on the method signature
02:23:07 <Keelhaul> yes
02:23:23 <Keelhaul> and if i call that method from another method, eclipse says a catch block is required
02:25:02 <bwolfe> you have to put "throws ___" in each method
02:25:08 <bwolfe> err "on" each method
02:25:48 <Keelhaul> i tried that too
02:25:49 <Keelhaul> Exception DocumentException is not compatible with throws clause in HttpServlet.doGet(HttpServletRequest, HttpServletResponse)
02:26:32 <bwolfe> ah, so catch it and do a "throw new ServletException("something bad happened", e);"
02:27:03 <Keelhaul> catch (DocumentException e) {
02:27:04 <Keelhaul> throw new ServletException(e);
02:27:06 <Keelhaul> will that do?
02:27:36 <bwolfe> Keelhaul: no, because that actually calls the ServletException(String) method and it does an e.toString()
02:27:52 <bwolfe> Keelhaul: you have to call ServletException("some explanation", e)
02:27:58 <Keelhaul> hm
02:28:18 <Keelhaul> ic
02:28:20 <Keelhaul> thx
03:30:42 *** bwolfe has quit IRC
03:39:29 <Keelhaul> gn
03:39:35 *** Keelhaul has quit IRC
07:05:17 *** jops87 has quit IRC
07:06:10 *** jops87 has joined #openmrs
11:31:05 *** atomicturtle has joined #openmrs
11:31:20 *** atomicturtle has left #openmrs
11:53:36 *** nribeka has joined #openmrs
12:05:37 *** nribeka3 has quit IRC
13:04:15 *** nribeka1 has joined #openmrs
13:08:01 *** james_regen has joined #openmrs
13:08:01 *** ChanServ sets mode: +v james_regen
13:15:17 *** nribeka has quit IRC
13:34:13 *** nribeka has joined #openmrs
13:49:56 *** bwolfe has joined #openmrs
13:49:56 *** ChanServ sets mode: +o bwolfe
13:52:45 *** nribeka1 has quit IRC
14:04:00 *** atomicturtle has joined #openmrs
14:04:25 *** atomicturtle has left #openmrs
14:04:36 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Google Summer Of Code 2009 <>
14:58:12 *** nribeka has quit IRC
16:03:08 *** nribeka has joined #openmrs
16:12:12 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #965 (task closed): Mongolian cyrillic characters don't entirely work <>
16:13:19 <nribeka> bwolfe, i think there are two test failing with the current trunk
16:13:27 <nribeka> could you please confirm it?
16:13:30 <bwolfe> uh oh
16:13:45 <bwolfe> will be reporting it soon if there are
16:13:54 <nribeka> i was about to upload hibernate and sha-512
16:13:58 <nribeka> hm
16:14:36 <nribeka> lemme check again :D
16:34:35 <nribeka> bwolfe, the build version is diff
16:34:46 <nribeka> in the CI: 6963
16:34:53 <nribeka> in the trunk: 6965
16:36:25 <nribeka> nvm bwolfe
16:50:53 *** Keelhaul has joined #openmrs
16:50:53 *** ChanServ sets mode: +v Keelhaul
17:05:56 *** Echidna_ has joined #openmrs
17:07:48 *** Echidna has quit IRC
17:12:01 <bwolfe> nribeka: what was the problem with the tests ? did you figure it out ?
17:13:03 <nribeka> i was re-running it
17:13:06 <nribeka> org.hibernate.NonUniqueObjectException: a different object with the same identifier value was already associated with the session: [org.openmrs.GlobalProperty#minSearchCharacters]
17:14:56 <nribeka> getPatients_shouldForceSearchStringToBeGreaterThanMinsearchcharactersGlobalProperty
17:16:26 <bwolfe> nribeka: so its working now ?
17:16:38 <nribeka> no :P
17:16:49 <nribeka> i was checking the ci
17:32:39 <Keelhaul> bwolfe: turns out clinicalsummary doesnt even use i-text
17:32:50 <Keelhaul> it uses FOP because it builds out of XSL-FO
17:34:02 <Keelhaul> arght, it's 2.15megs
17:34:05 <Keelhaul> damn
17:35:59 <bwolfe> Keelhaul: right
17:36:17 <Keelhaul> bwolfe: maybe you can give me a hint
17:36:25 <Keelhaul> i have an xml doc that i need to get to the servlet somehow
17:36:38 <Keelhaul> the workflow is: the user clicks on the pdf icon and gets a new window with the pdf inside
17:36:51 <Keelhaul> i thought i can send the xml via POST
17:37:05 <Keelhaul> that jsp already contains a POST form
17:37:12 <Keelhaul> thats for different purposes
17:40:01 <Keelhaul> i dont wanna serialize again
17:40:02 <Keelhaul> or use the db
17:42:41 *** nribeka has quit IRC
17:46:23 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Changesets: Changeset [6967]: Pruning the ticket974-liquibase branch as it has been merged into trunk … <> || OpenMRS Changesets: Changeset [6966]: foodprogram: * upgraded module to openmrs-1.4 * in process of … <>
17:55:51 <Keelhaul> bwolfe: also, it seems i can only use the person search tags if my command object is defined in hibernate or something, right?
17:55:53 <Keelhaul> <openmrs_tag:personField formFieldName="personId"
17:56:22 <bwolfe> Keelhaul: you can add another <form> tag with a different post address in it
17:56:56 <bwolfe> Keelhaul: no, not right. you should be able to use those tags even if you don't have your object in hibernate
17:57:46 <Keelhaul> hmm
17:57:56 <Keelhaul> it doesnt save the person
17:57:57 <Keelhaul> weird
18:02:34 <bwolfe> Keelhaul: um, you would have to call savePerson in your controller to have that happen
18:03:24 <Keelhaul> save as in myobject.person = person i selected
18:03:39 <Keelhaul> after i send the form, the box is empty again
18:05:52 <bwolfe> not sure what you mean Keelhaul
18:06:02 <bwolfe> perhaps go through your entire workflow ?
18:06:05 <bwolfe> brb
18:06:07 <Keelhaul> ok
18:06:35 <Keelhaul> my non-persistent object has a member called "recipient" which is an org.openmrs.Person
18:06:48 <Keelhaul> and i have a form for that object that has a person select tag
18:07:12 <Keelhaul> and i need it to be assigned to recipient after i send the form
18:07:14 <Keelhaul> but it doesnt happen
18:07:55 *** bwolfe has quit IRC
18:09:45 *** bwolfe has joined #openmrs
18:09:45 *** ChanServ sets mode: +o bwolfe
18:11:22 <Keelhaul> wb
18:11:26 <Keelhaul> [19:06:13] <+Keelhaul> my non-persistent object has a member called "recipient" which is an org.openmrs.Person
18:11:26 <Keelhaul> [19:06:26] <+Keelhaul> and i have a form for that object that has a person select tag
18:11:26 <Keelhaul> [19:06:49] <+Keelhaul> and i need it to be assigned to recipient after i send the form
18:11:26 <Keelhaul> [19:06:51] <+Keelhaul> but it doesnt happen
18:14:03 <bwolfe> ok, so you just want keelhaulObject.recipient to equal the person id that they choose ?
18:14:13 <Keelhaul> yes
18:14:29 <Keelhaul> spring.bind is set correctly around the tag
18:14:32 <bwolfe> that should work just fine
18:14:34 <Keelhaul> err spring:bind
18:14:42 <bwolfe> whats your tag look like ?
18:15:15 <Keelhaul> pm
18:15:45 <bwolfe> set formFieldName to ${status.expression}
18:17:43 <Keelhaul> ah seems to work now
18:17:45 <Keelhaul> thanks
18:18:06 <Keelhaul> why is formFieldName usually explicitly set to a name in other forms
18:18:12 <Keelhaul> like providerId
18:18:15 <Keelhaul> or patientId
18:19:00 <bwolfe> dunno
18:19:17 <bwolfe> people ${status.expression} really turns out to be providerId or patientId ? :-)
18:20:02 <Keelhaul> also, i cant bind to input type="checkbox"?
18:22:52 <bwolfe> yeah, you should be able to
18:22:58 <bwolfe> you bind to the whole set of them though
18:23:17 <bwolfe> Keelhaul: or you can use the cool spring 1.5 <spring:form> tags
18:23:37 <bwolfe> they do all the binding, etc magic with a lot of the form elements
18:23:44 <Keelhaul> rly
18:23:45 <Keelhaul> hm
18:25:37 <Keelhaul> lol you try to conform to xhtml and use checked="value" instead of just checked
18:25:48 <Keelhaul> and then checked="false" is interpreted as true
18:25:53 <Keelhaul> how counterintuitive is that
18:42:30 <Keelhaul> ok i see why my checkboxes update when i check them but not when i uncheck them
18:42:39 <Keelhaul> there needs to be a second input type="hidden"
18:42:48 *** nribeka has joined #openmrs
18:43:36 <bwolfe> Keelhaul: yeah, <input type="hidden" name="_${status.expression}" value="" />
18:43:45 <bwolfe> spring understands the underscore
18:43:51 <Keelhaul> is value really needed?
18:44:23 <Keelhaul> but i cant find example of the new spring 2.0 tags anywhere
18:44:26 <Keelhaul> +s
18:45:40 <nribeka> bwolfe, the CI works fine
18:45:51 <nribeka> why it's failing on me :(
18:48:14 <bwolfe> nribeka: did you try a clean run of hte test s?
18:48:21 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #1256 (task closed): Fix Dojo Javascript Paging <> || OpenMRS Changesets: Changeset [6968]: Removed javascript "smart" paging and instead just display results 20 at a … <>
18:48:28 <bwolfe> nribeka: are you using the junit-report ? or right clicking on test/api ?
18:48:29 <nribeka> running it now. clean test
18:48:34 <nribeka> right click
18:55:15 <bwolfe> nribeka: yeah, you can use the eclipse junit environment to run tests on everything just as you do for one test
18:55:29 <bwolfe> just right click on the base package and choose run as --> unit test
18:59:47 <nribeka> BUILD SUCCESSFUL using the ant junit-test
18:59:53 <nribeka> but fail on right click
19:19:27 <Keelhaul> bwolfe: for (PatientIdentifier pi : getEncounter().getPatient().getIdentifiers()) {
19:19:34 <Keelhaul> why does this give me a lazyinitiationexception
19:19:49 <Keelhaul> err initialization
19:24:22 <bwolfe> Keelhaul: because you're not in the session ?
19:24:27 <bwolfe> are you in a jsp apge ?
19:24:31 <bwolfe> or a controller ?
19:24:39 <bwolfe> is @Transactional on your service(s) ?
19:24:47 <bwolfe> (the interfaces)
19:25:21 <Keelhaul> no services
19:25:33 <Keelhaul> it happens within that object we talked about before
19:25:39 <Keelhaul> it has no db table or services
19:25:53 <Keelhaul> it has an Encounter as its member
19:26:02 <Keelhaul> and pulls a lot of information via that
19:37:41 *** Echidna has joined #openmrs
19:41:19 *** Echidna_ has quit IRC
19:50:36 <bwolfe> Keelhaul: as long as that encounter is being used across a submit you should be fine
19:50:52 <bwolfe> you can't use "sessionForm=true" in the spring application context for that controller
19:52:42 <Keelhaul> it is a sessionForm
19:53:00 <Keelhaul> i need to keep the object over a submit
19:53:06 <Keelhaul> so
19:53:32 <Keelhaul> the first formBackingObject call has a ?encounterId=n
19:54:21 <Keelhaul> and formBackingObject constructs the command object and sets object.encounter = es.getEncounter(encounterId);
19:54:52 <Keelhaul> and that part of the object remains unchanged over a submit
20:05:22 <Keelhaul> bwolfe: how about this
20:05:23 <Keelhaul> Patient p = Context.getPatientService().getPatient(getEncounter().getPatientId());
20:05:23 <Keelhaul> for (PatientIdentifier pi : p.getIdentifiers()) {
20:08:35 <bwolfe> Keelhaul: yeah, if you fetch the patient object again after the submit you shouldn't have a problem
20:08:48 <bwolfe> its when you try to keep that same patient object that things break
20:08:52 <bwolfe> brb
20:08:55 *** bwolfe has quit IRC
20:11:08 *** bwolfe has joined #openmrs
20:11:08 *** ChanServ sets mode: +o bwolfe
20:31:07 <Keelhaul> bwolfe: is there any way to record allergies besides obs?
20:31:26 <bwolfe> Keelhaul: not right now
20:31:46 <bwolfe> Keelhaul: there is a ticket for us to make an "active list" type of data storage, but we haven't gotten to it yet
20:31:55 <bwolfe> Keelhaul: it would probably involve a new table
20:32:07 <bwolfe> and would be similar to how the current orders are kept
20:32:16 <Keelhaul> do orders work?
20:32:18 <bwolfe> Keelhaul: want to take that one on ? :-D
20:32:21 <bwolfe> Keelhaul: yeah, they should !
20:32:23 <Keelhaul> not right now =/
20:32:24 <nribeka> bwolfe, if i attach a patch to ticket, is it going to send any email? :P
20:32:26 <bwolfe> the pih guys are using them
20:32:30 <bwolfe> nribeka: nope
20:32:37 <bwolfe> nribeka: you have to comment on it to send the email
20:32:42 *** Keelhaul has quit IRC
20:32:48 *** Keelhaul has joined #openmrs
20:32:48 *** ChanServ sets mode: +v Keelhaul
20:32:52 <bwolfe> nribeka: (Which is quite annoying)
20:33:22 <nribeka> ooo ic ic. i attach patch to the hibernate
20:33:26 <nribeka> i will put a comment :)
21:24:27 *** james_regen has quit IRC
21:31:11 <basic`> bwolfe: re your email, im about to leave for a meeting, but i think that is a good idea and dev2 wont be hard
21:31:27 <bwolfe> basic`: sweet
21:31:28 <basic`> the only issue is that there is no official 0.11 rpm for centos, we have a custom one but it hasn't had much testing
21:31:47 <bwolfe> basic`: I thought you've upgraded 5-10 or so other people
21:31:57 <basic`> i'll start working on that this week
21:32:06 <basic`> bwolfe: yes, but those were on a gentoo VM
21:32:16 <bwolfe> oh
21:32:19 <basic`> i *think* our rpm works, i just need to test it out
21:32:23 <bwolfe> thats unfortunate
21:32:24 <bwolfe> heh
21:32:25 <basic`> if it doesnt, i can make it go :)
21:32:31 <bwolfe> well, all the more reason to have a dev2 then ! :-)
21:32:35 <basic`> exactly
21:33:22 <basic`> i've also got a dedicated postgresql server setup, so far it's been pretty quick for trac (faster than sqlite)
21:33:55 <bwolfe> basic`: the only reason I asked as I did is because there will probably be tickets, comments, etc between when you start the upgrade and when we finally "approve" it, so it won't be as easy as just changing dev2 to dev
21:34:07 <bwolfe> basic`: nice
21:34:21 <basic`> anyways, i'll get an email back to you and start working on that, hopefully i can have it ready to play with by friday
21:34:44 <basic`> and ya, we'll have to take a slight downtime to get things synced up, but that shouldn't take very long
21:35:06 <basic`> gotta run, ttyl
21:35:10 <bwolfe> cya
21:36:58 <Keelhaul> wooo
21:37:01 <Keelhaul> cardio ftw
21:40:39 *** nribeka1 has joined #openmrs
21:58:11 *** nribeka has quit IRC
22:13:38 *** [mharrison] has quit IRC
22:21:32 <Keelhaul> bwolfe: what does jmiranda mean by you're going to make the changes from the review?
22:22:20 <bwolfe> Keelhaul: there was really only one change, so before I commit it to trunk, I'm going to make the simple change.
22:22:28 <Keelhaul> ok
22:22:33 <bwolfe> Keelhaul: basically it means: "don't worry about a thing". :-)
22:22:36 <Keelhaul> and about that many to many mapping
22:22:47 <bwolfe> still under discussion
22:22:50 <Keelhaul> you sure it can be done later w/o losing existing hierarchies?
22:26:57 <bwolfe> Keelhaul: yeah, it would just be moving the parent_location column out into a map type of table
22:27:15 <Keelhaul> yea i guess
22:27:17 *** atomicturtle has joined #openmrs
22:27:22 <Keelhaul> since all have the same types
22:27:39 <Keelhaul> i'm not sure how to do the transition with my current hierarchy
22:27:51 <Keelhaul> since each is an own table atm with own running ids
22:27:57 *** atomicturtle has left #openmrs
22:32:26 *** nribeka has joined #openmrs
22:38:20 *** nribeka1 has quit IRC
22:42:39 *** Echidna_ has joined #openmrs
22:47:28 *** Echidna has quit IRC
23:07:20 <bwolfe> Keelhaul: you'll have to convert each different "layer" in the hierarchy to a normal location and they all get new location ids ?
23:30:08 *** bwolfe has quit IRC
  • No labels