Wiki Spaces

Documentation
Projects
Resources

Get Help from Others

Q&A: Ask OpenMRS »
Discussion: OpenMRS Talk »
Real-Time: IRC Chat

IRC Logs

Child pages
  • 2008-07-07 - OpenMRS
Skip to end of metadata
Go to start of metadata
01:23:19 *** nribeka_ has joined #openmrs
01:25:49 *** nribeka has quit IRC
02:28:12 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: MRN Generator Module 1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=mrngen&version=&1.0>
02:37:59 *** njero_ has joined #openmrs
02:38:03 *** njero has quit IRC
03:19:01 *** njero has joined #openmrs
03:19:01 *** ChanServ sets mode: +v njero
03:19:02 *** njero_ has quit IRC
03:19:31 *** njero has quit IRC
03:20:01 *** njero has joined #openmrs
03:20:01 *** ChanServ sets mode: +v njero
03:37:38 *** nribeka_ has quit IRC
03:45:42 *** njero has quit IRC
03:46:22 *** njero has joined #openmrs
03:46:22 *** ChanServ sets mode: +v njero
04:07:11 *** TorLye has joined #openmrs
04:27:03 *** maveriick has joined #openmrs
04:39:09 <maveriick> ah! htmlinlcude
05:20:19 *** upul has quit IRC
05:20:43 *** upul has joined #openmrs
06:16:02 *** james_regen has joined #openmrs
06:16:02 *** ChanServ sets mode: +v james_regen
06:26:01 *** sioraiocht has joined #openmrs
06:53:26 *** njero has quit IRC
07:15:42 *** bwolfe has joined #openmrs
07:15:42 *** ChanServ sets mode: +o bwolfe
07:17:36 *** upul has quit IRC
07:41:19 *** nribeka has joined #openmrs
07:47:20 *** maveriick has quit IRC
08:15:50 *** upul has joined #openmrs
08:21:11 <upul> Good morning bwolfe
08:21:33 <bwolfe> hey upul
08:21:43 <upul> how was the weekend?
08:22:18 <bwolfe> it went well
08:22:29 <bwolfe> had to play a double header soccer game yesterday though
08:22:34 <bwolfe> very sore this morning
08:22:53 <upul> i have to check what double header soccer means
08:23:24 <bwolfe> although I went water skiing on saturday and played basketball this morning...so my soreness could be caused by a few things :-p
08:23:30 <bwolfe> it just means we had two games
08:23:54 <upul> very active life :-)
08:24:55 <upul> about the ticket, http://dev.openmrs.org/ticket/652
08:25:20 <upul> the last comment, i didn't get it
08:25:52 <upul> i have restored a page at the old location
08:26:14 <bwolfe> upul: yes, but only restored it in the tribe module
08:26:44 <bwolfe> I was thinking of users that don't have the tribe module yet
08:30:31 <upul> i thought i had it, may be i forgot to add the page to the svn, i'll check that
08:32:39 *** upul has quit IRC
08:37:50 *** upul has joined #openmrs
08:43:09 *** atomicturtle has quit IRC
08:46:48 *** sioraiocht has quit IRC
09:06:21 *** cancerb0y has joined #openmrs
09:08:57 <upul> bwolfe i attached the latest patch it was getting mixed up with the privilege patch
09:12:47 <bwolfe> upul: ok
09:12:58 <bwolfe> upul: are you saying that you have another patch?
09:14:00 <upul> no i mean i'm keeping two openmrses for this and that privilege ticket, somehow some of that patch changes were in this tribe patch
09:15:22 <upul> why is that i can't see the colored view for the patch?
09:15:23 <upul> http://dev.openmrs.org/attachment/ticket/652/openmrs-652.patch
09:15:27 <OpenMRSBot> <http://ln-s.net/20wq> (at dev.openmrs.org)
09:15:38 <upul> is there a size limit
09:18:34 *** atomicturtle has joined #openmrs
09:18:48 <bwolfe> a size limit to the patches ?
09:19:07 <upul> i mean that nice red and green view
09:19:35 <bwolfe> interesting, I didn't know of one
09:20:07 <bwolfe> that new patch is only 4k larger than the one thats showing
09:24:10 <upul> bwolfe anyway what would you suggest for the update project?
09:25:14 <upul> tribe thing finished, unless there are mixups in the patches
09:26:19 <bwolfe> upul: new patch looks right
09:27:36 <upul> there are too many but-not-the-best options for the update project
09:27:53 <bwolfe> yeah
09:28:03 <bwolfe> webstart is not an option
09:28:40 <upul> instead of a single war file, if it shared as a exploded directory
09:29:25 <upul> then instead of rsync we can do file synchronization of the directory
09:29:33 <bwolfe> having the sql update built into the openmrs war would be a cool option. your other updateopenmrs.war file would then only have to worry about dropping a new war into place
09:34:10 <upul> bwolfe: something like this http://syncdir.sourceforge.net
09:34:45 <upul> if this is possible then the war has to be in the server in exploded format
09:35:04 <bwolfe> upul: I'm not sure we can always guarantee that
09:35:21 <bwolfe> ""Synchronize a specified target directory or file""
09:35:26 <bwolfe> __or file__
09:35:57 <bwolfe> so as long as they have a copy of the previous war around somewhere
09:37:16 <bwolfe> upul: does that syncdir code work over a network though?
09:38:32 *** maveriick has joined #openmrs
09:38:39 *** sioraiocht has joined #openmrs
09:39:22 <upul> bwolfe: may be not. if we can limit those jars from downloading like maven is doing
09:42:36 <bwolfe> upul: how about you worry about the rsync stuff second?
09:42:53 <bwolfe> upul: for the first deliverable you don't need to have that in there
09:44:14 <bwolfe> upul: you can give the admin the option of either downloading automatically through your code or providing the new war file that they already downloaded themselves
09:45:41 *** atomicturtle1 has joined #openmrs
09:46:39 <upul> bwolfe: ok
09:53:42 <maveriick> bwolfe: hi
09:53:53 <bwolfe> hey
09:56:31 <maveriick> I am trying to add a folder full of js and other helper files of tinyMCE and later added the main js file via openmrs:htmlInclude in jsp file. Everything is fine except the image files/icons are not loaded properly. On top of my description do you see any problem? :)
09:56:52 <maveriick> i have added it the same way, as the flot package is used in form entry module
09:57:37 <bwolfe> maveriick: lucky for you sunbiz ran into this the other day
09:57:55 <maveriick> I have added that to a sample controller outside openMRS via script src and it works like a charm...
09:58:58 <maveriick> bwolfe: how did he survive?
10:00:11 <bwolfe> maveriick: http://dev.openmrs.org/changeset/4830
10:00:18 <bwolfe> do that change to your build.xml file in your module
10:00:27 <bwolfe> and then do a clean build of your module
10:01:12 *** atomicturtle has quit IRC
10:09:33 *** njero has joined #openmrs
10:09:33 *** ChanServ sets mode: +v njero
10:17:30 <maveriick> Cool! works perfectly .... I ruined the whole day ....guessing about tinyMCE, openMRS, FF3 bug and others ...nagging with firebug... :(
10:20:55 *** atomicturtle has joined #openmrs
10:20:55 *** atomicturtle1 has quit IRC
10:21:12 <bwolfe> maveriick: sorry :-/
10:23:54 <maveriick> bwolfe: nothing to be sorry ....thats life ... :)
10:24:30 *** cancerb01 has joined #openmrs
10:24:43 *** sioraioc_ has joined #openmrs
10:25:27 *** sioraioc_ is now known as sioraiocht_
10:25:50 *** sioraiocht has quit IRC
10:25:54 *** sioraiocht_ is now known as sioraiocht
10:33:57 *** maveriick has quit IRC
10:43:01 *** cancerb0y has quit IRC
10:56:46 *** upul has quit IRC
10:58:30 *** upul has joined #openmrs
11:24:58 *** pombreda has quit IRC
11:30:59 <r0bby> bwolfe: I had to redo how i present my template to users :/
11:31:17 <r0bby> it's now presented as a series of method calls :/
11:34:50 <cancerb01> bwolfe: do u have any idea about how to get rid of the extra lines here http://machosry.googlepages.com/1.png ... this is my passed json http://pastebin.com/d466cd841
11:51:20 <r0bby> jesus christ -- There's a whole thread on the groovy-user list about omitting 'new'
12:10:22 *** cancerb0y has joined #openmrs
12:16:49 *** sgrannis has joined #openmrs
12:16:56 <sgrannis> nribeka: hey!
12:17:05 <sgrannis> how're things?
12:17:24 <nribeka> hi sgrannis :D
12:17:25 <nribeka> i sent you the latest patch
12:17:52 <nribeka> and i talk to james early on about adding the blocking variable to the screen
12:18:07 <nribeka> have u seen the screenshot that i sent?
12:19:18 <r0bby> meh
12:19:21 <r0bby> I hate you nribeka
12:19:30 <r0bby> your project seems to be a bit easier
12:19:40 <nribeka> hehe :D
12:19:55 <nribeka> you should've pick my project then rob haha ... lol
12:20:16 <r0bby> nribeka: I thought mine would be easier
12:20:24 <r0bby> it's fun when things are going my way
12:20:49 <nribeka> it's fun too. i can learn about spring :D
12:21:19 <r0bby> nobody learns about spring
12:21:22 <r0bby> it's black magic
12:21:30 <r0bby> Rod Johnson is a witch
12:21:33 *** sunbiz has joined #openmrs
12:21:42 <r0bby> pointy hat, broomstick
12:21:55 * r0bby snickers evilly
12:23:10 <sunbiz> hi guys
12:23:17 <nribeka> haha ... it's interesting. kinda confusing at first
12:23:26 <nribeka> hi sunbiz
12:23:37 <sunbiz> r we using Servlet API 2.4 or higher ?? Or can be using a lower servlet API !??
12:23:37 <sgrannis> nribeka: did you have a good holiday
12:23:52 <sunbiz> hi nribeka
12:24:52 <sunbiz> bwolfe: any thoughts on showing spring messages through Servlets ??
12:25:02 <nribeka> sgrannis: yeah, birthday party at my friend place :D
12:25:10 <r0bby> That's one question i've been meaning to ask
12:25:10 <sgrannis> great
12:25:20 <nribeka> firework on 4th of July
12:25:21 <sgrannis> when did you send the patch?
12:25:23 *** cancerb02 has joined #openmrs
12:25:30 <r0bby> I settled on using dwr -(
12:25:31 <r0bby> =)
12:25:36 <sgrannis> nice -- fireworks are cool
12:25:42 <r0bby> use DWR where i need internationalization
12:26:03 <nribeka> july 3rd, right after you send me email
12:26:06 *** cancerb01 has quit IRC
12:26:33 <sgrannis> ahhh -- lemme check ... thought I had responded ... 1 sec
12:27:25 <sunbiz> r0bby: but Im sure there is a way to use Spring messages directly
12:28:07 <r0bby> I have a servlet solely dedicated to returning AJAX messages
12:28:22 <r0bby> I'm pretty sure it gets axed in the code review
12:28:38 <sunbiz> what gets axed ?
12:28:44 <sgrannis> sorry -- your email was labeled as spam and put in my spam folder... has james seen the patch?
12:29:43 <james_regen> i've looked over the patch briefly
12:29:56 <sgrannis> james_regen: thoughts?
12:30:03 <r0bby> the servlet
12:30:19 <bwolfe> cancerb0y / cancerb02 : can you show the json message in a more readable format ?
12:30:42 <bwolfe> sunbiz: I don't know how to do that. use a controller and its done for you :-)
12:30:51 * r0bby growls
12:31:02 <r0bby> bwolfe: is it okay to be going coocoo?
12:31:12 <sunbiz> bwolfe: ok...
12:31:15 <r0bby> I think you're to blame
12:31:21 <r0bby> somehow
12:31:32 <jacobb> hey bwolfe, i'm trying to modify obs's manually and i'm getting "a different object with the same identifier value was already associated with the session"
12:31:45 <bwolfe> jacobb: with trunk?
12:31:53 <jacobb> in my own code
12:31:56 <bwolfe> r0bby: yes, sanity is actually forbidden
12:31:57 <jacobb> it's a problem w/ my code i'm sure
12:32:04 <jacobb> jsut wondering if you know what i could be doing wrong
12:32:21 <bwolfe> jacobb: you're creating two objects with the same obs_id
12:32:31 <bwolfe> Obs o1 = obsSErvice.getObs(1);
12:32:37 *** cancerb0y has quit IRC
12:32:38 <bwolfe> Obs o2 = obsService.getObs(2);
12:32:44 <bwolfe> hibernate doesn't like it when you do that
12:32:53 <james_regen> i think the patch looks alright. i think it can be committed now, or it can wait until the blocking variable stuff is added
12:33:04 <jacobb> oh
12:33:11 <jacobb> so i can't get two diff ones at the same time?
12:33:54 <jacobb> I call obsService.saveObs(obs, editReason);
12:33:57 <nribeka> should i commit it now? or wait for it? i think it won't take long to add just one field
12:34:12 <nribeka> just need to decide on ordering stuff
12:35:37 <cancerb02> bwolfe: hope this helps http://pastebin.com/d7dc0d3d7
12:35:38 <jacobb> after traversing through some encounter's obs's and holding onto the one i want to edit and update
12:36:56 *** bmckown has joined #openmrs
12:36:56 *** ChanServ sets mode: +o bmckown
12:37:35 *** nribeka has quit IRC
12:37:38 *** vagrawal has quit IRC
12:37:43 *** nribeka has joined #openmrs
12:37:43 <bwolfe> cancerb02: ff or ie ?
12:37:53 <bwolfe> cancerb02: with the dojo in openmrs, or your own dojo ?
12:38:23 *** cancerb0y has joined #openmrs
12:38:24 <bwolfe> jacobb: can you pastebin your code snippet?
12:38:30 <bwolfe> cancerb02: ff or ie ?
12:38:30 <bwolfe> <bwolfe> cancerb02: with the dojo in openmrs, or your own dojo ?
12:38:31 <jacobb> ya
12:39:00 <cancerb0y> bwolfe: in firefox and i use the dojo in openmrs
12:39:06 <james_regen> nribeka: sure, go ahead and commit now
12:40:02 <jacobb> bwolfe: http://pastebin.com/d6e9d4cdf
12:40:48 <sgrannis> nribeka: i'd vote for committing ...
12:41:07 <nribeka> ok ok :D
12:41:20 <nribeka> commiting ...
12:41:48 <bwolfe> jacobb: its probably this bit that is screwing you up: "Context.getConceptService().getConceptByName(conceptName)"
12:42:02 *** sunbiz has left #openmrs
12:42:21 * r0bby humps his jquery
12:42:24 <bwolfe> jacobb: get that first, then just do a existingObs.getConcept().equals(conceptByName)
12:42:32 <bwolfe> jacobb: at line 8
12:43:11 <jacobb> ok let me give it a shot
12:45:18 <cancerb0y> bwolfe: if i have some 1.html i need to bring tat in my admin list.. i tried directly inserting the link in the adminlist using map with a title... but the link is not working in the admin page
12:45:41 <cancerb0y> bwolfe: http://pastebin.com/d59bcdbb8
12:45:51 <cancerb0y> bmckown: hi Brian
12:46:08 <cancerb0y> bmckown: I am done with the javascript tree :)
12:46:32 <bmckown> cool!
12:46:33 <bwolfe> cancerb02: use module/addresshierarchy/addresshierarchyTree.htm instead of existingObs.getConcept()
12:46:36 <bwolfe> err
12:46:45 <bwolfe> cancerb02: use module/addresshierarchy/addresshierarchyTree.htm instead of module/addresshierarchy/addresshierarchyTree.jsp
12:47:33 <jacobb> bwolfe: same problem
12:48:12 <jacobb> http://pastebin.com/m55b975a3 I pasted my update
12:48:36 <cancerb0y> bwolfe: cool that works
12:49:18 <jacobb> p.s. i hate firefox 3
12:49:28 <cancerb0y> bwolfe: but what about that extra line?
12:51:09 <bwolfe> cancerb02: not sure
12:51:23 <bwolfe> cancerb02: anything weird in the source of the page
12:51:24 <bwolfe> ?
12:52:07 <sgrannis> nribeka: screen shots look good
12:52:21 <cancerb0y> bwolfe: no clues at all
12:52:43 <cancerb0y> bwolfe: but y few js scripts are not working in ie
12:52:53 <bwolfe> cancerb02: ff will let you highlight the page, then do "show selection source" to see what html is generated by javascript
12:53:20 <bwolfe> jacobb: does this happen for new obs or for edited obs?
12:53:23 <nribeka> sgrannis + james_regen: the changes has been committed
12:53:29 <jacobb> just edited
12:53:53 <sgrannis> nribeka: thx -- will take a look.
12:54:00 <jacobb> at least i think so
12:54:01 <jacobb> let me test it
12:54:56 *** cancerb02 has quit IRC
12:55:04 <nribeka> give me some feedback sgrannis + james_regen :D
12:55:45 <jacobb> bwolfe: just edited
12:56:34 <cancerb0y> bwolfe: the json doesnot works properly with the ie... the servlet send the json well in ff but in ie it retains the first json sent by the servlet at the start of the session
12:57:40 <jacobb> bwolfe: another strange tidbit, when I finally added a new obs, the id of it had jumped from 2 to 17...likely from all the failures of editing. Not sure if that indicates where/when it's failing
12:58:30 <bwolfe> jacobb: and your db doesn't have a 3-16 ?
12:58:34 <jacobb> nope
12:58:40 <jacobb> just checked
13:03:09 <bwolfe> jacobb: hmm
13:03:26 <bwolfe> cancerb0y: I don't know it'd be failing
13:03:51 <bwolfe> cancerb0y: although I know that FF will allow things like {'asdf', 'asdf', 'asdf',} and IE will not (note the trailing comma)
13:08:07 <cancerb0y> bwolfe: but for the first time it loads the tree properly with the json from servlet but then until u restart the session the json remains the same i mean the page uses the old json not the new one.. plus few scripts doesnt work... like line 67 and 107 dont work... http://pastebin.com/d41e13b13
13:08:20 <cancerb0y> bwolfe: have i done any mistake in this??
13:08:57 <cancerb0y> bwolfe: the thing is everything is updated clearly in the db but doesnt shows up in the ie
13:09:08 <cancerb0y> in ff everything is pretty fine
13:10:57 <bwolfe> cancerb0y: how is newname getting to the function in 107 ?
13:11:10 <jacobb> bwolfe, I'll be right back, going to reboot
13:11:14 <nribeka> sgrannis + james_regen: off for a few mins. will be back
13:11:41 *** jacobb has quit IRC
13:12:09 *** nribeka has quit IRC
13:12:27 <cancerb0y> bwolfe: i have a prompt box for tat at line 105
13:13:27 <cancerb0y> bwolfe: sometimes they work.. i think the reason for the problem is the incorrect json loaded by the servlet
13:15:42 *** jacobb has joined #openmrs
13:18:41 <bwolfe> cancerb0y: so some caching maybe ?
13:18:49 <bwolfe> cancerb0y: turn off your caching in ie
13:19:10 <bwolfe> and if that fixes it, you can set some html headers to make sure it doesn't happen
13:25:58 <r0bby> response.setHeader("Cache-Control","no-cache");
13:26:07 <r0bby> ^^ do that before you return anything
13:26:22 <r0bby> I do that before all of my AJAX responses
13:26:35 <r0bby> this will eliminate anything going awry
13:28:41 <cancerb0y> thanks a lot bwolfe and r0bby
13:29:27 *** sgrannis has quit IRC
13:30:30 <cancerb0y> bwolfe: is there any way to build a js tree with out using json array and with different source?
13:30:48 <bwolfe> cancerb0y: what do you mean by different source /
13:30:54 <bwolfe> /==?
13:31:26 <cancerb0y> bwolfe: i mean generally we use json array to build a tree is there any other way to do the same?
13:31:41 <cancerb0y> using anything istead of json array
13:31:50 <bwolfe> cancerb0y: I think you can use html
13:32:05 <bwolfe> but I'm not sure
13:32:14 <bwolfe> its been a long time since I did stuff with the js tree
13:32:43 <cancerb0y> but i must get data from db... if the data are hardcoded then i can use html but i m getting the data from db
13:38:45 * r0bby is filling out the survey
13:38:56 <r0bby> it's all posititive just a few things
13:42:08 *** upul has quit IRC
13:44:02 *** nribeka has joined #openmrs
13:45:33 <r0bby> andd dont :)
13:45:52 <r0bby> \done*
13:45:53 <bwolfe> hey cool, we have a leslie lurking here now :-)
13:46:06 <bwolfe> welcome
13:46:10 <r0bby> i think she's gonna complain about me acting up and my big mouth lol
13:46:18 * r0bby is always paranoid :/
13:46:19 <bwolfe> r0bby: I think that'll make you the first to be done for openmrs
13:46:31 <r0bby> I'm done
13:46:51 <jacobb> bwolfe, any other ideas on the obs issue?
13:47:00 <r0bby> I did mention i'd like burke to be there more, but turned it into a positive note
13:47:14 <bwolfe> jacobb: not sure. it could be the funky way that the obs does the obs_id change
13:47:17 <r0bby> bwolfe: what sucks is that burke sees it
13:47:35 <bwolfe> (because obs are the only objects that never update...always void and insert new)
13:47:36 <jacobb> yeah but the obsformcontroller is workign fine
13:47:37 <jacobb> with saveObs
13:48:26 <bwolfe> r0bby: are you sure? I thought only google saw what you put in
13:48:54 <bwolfe> jacobb: right, but you're fetching the obs, then saving. while saving it fetches the obs and voids it.
13:49:00 <r0bby> google and project adnubs
13:49:01 <jacobb> yeah
13:49:01 <r0bby> admins
13:49:09 <jacobb> wondeirng how obsFormController handles it though
13:49:11 <jacobb> that's different
13:49:11 <r0bby> burke/paul are project admins i think
13:49:30 <bwolfe> r0bby: ok, if admins see it, then yes, burke will see it :-p
13:49:41 <r0bby> damn it
13:49:45 * r0bby writes bad things
13:50:01 <r0bby> bwolfe: i did mention that co-mentors should understand the technologies that their students are using :P
13:50:05 <r0bby> ie learn groovy
13:50:27 <jacobb> b/c obsFormController grabs the current obs, then saves it, which shoudl do the same thing..
13:51:29 <r0bby> lh: one complaint
13:51:35 <r0bby> question 21 on the student survey
13:51:40 <r0bby> what if we had no hard points?
13:51:58 <r0bby> making that optional would make more sense.
13:52:07 <r0bby> </survey feedback>
13:52:35 *** cancerb0y has left #openmrs
13:54:49 <r0bby> bwolfe: I hope you're not against using AJAX to create the form entirely
13:55:36 <r0bby> because that's what its turning into :<
13:56:02 <r0bby> I'm using it to return the controller/final markup
13:56:08 * r0bby dances
13:56:17 <bwolfe> r0bby: I am
13:56:22 <bwolfe> :-)
13:56:28 <r0bby> sucks to be you
13:56:52 <bwolfe> r0bby: but it can be changed fairly easily. its harder to go from nonajax to ajax than it is to do ajax->nonajax
13:56:52 <r0bby> find me a better way to give me flexibility of where i display error messages
13:57:19 <r0bby> this is only the first pass
13:57:33 <r0bby> there's gonna be some massive refactoring later on anyways
14:05:47 <jacobb> bwolfe, is there any other way i could fetch the obs ot be more similar to the formcontroller
14:05:59 <jacobb> not sure wha thte problem could be
14:06:09 *** sioraiocht has quit IRC
14:06:36 <jacobb> you think it's b/c hibernate knows i'm holding it and coudl modify it
14:06:37 <jacobb> ?
14:07:42 <bwolfe> jacobb: something like that, yeah
14:08:20 <jacobb> any way to "de-sync" it
14:08:20 <jacobb> ?
14:08:35 <bwolfe> jacobb: try using the encounter.getAllObs() method
14:08:52 <jacobb> sure, what's the difference?
14:10:44 <jacobb> same problem..
14:12:59 <bwolfe> jacobb: does it tell you what type of object ?
14:13:02 <bwolfe> or what identifier ?
14:13:49 * r0bby stabs IDEA
14:14:24 <jacobb> yeah it tells me Obs#id
14:14:40 <jacobb> where whichever id is the one i'm trying to update
14:14:52 <jacobb> i tried doing Context.evictFromSession(obs) before i call save
14:15:02 <jacobb> but i got a diff error saying no session or session was lcosed
14:15:03 <jacobb> :)
14:15:08 <jacobb> failed to lazily initialize a collection of role: org.openmrs.Obs.groupMembers, no session or session was closed
14:17:21 <bwolfe> jacobb: are you editing grouped obs ?
14:17:31 <jacobb> no
14:17:41 <bwolfe> jacobb: can you duplicate this in a test method at all ?
14:17:47 <jacobb> but that's the error i got when i evicted it first
14:18:11 <jacobb> bwolfe...not sure, haven't tried
14:18:19 <jacobb> is there currently a test that modifies a saved obs?
14:19:38 <jacobb> yeah, i see it, ObsServiceTest.java
14:21:02 *** sgrannis has joined #openmrs
14:21:11 *** ChanServ sets mode: +v sgrannis
14:25:05 * r0bby throws a chair at sgrannis and runs
14:25:27 <r0bby> sorry been watching springer too much :)
14:25:36 <r0bby> that and IDEA is bugging me
14:33:00 <jacobb> bwolfe, so it's not the loop, i got the obs manually with getObs(id) and still had hte same issue
14:33:20 <bwolfe> jacobb: hmm
14:33:22 <bwolfe> thats odd
14:33:31 <bwolfe> thats all the controller is doing really
14:34:41 *** pombreda has joined #openmrs
14:34:41 *** ChanServ sets mode: +v pombreda
14:39:38 <jacobb> bwolfe...when i google it i get a lot of spring errors
14:39:49 <jacobb> spring + hibernate
14:40:14 <bwolfe> jacobb: pastebin what you have now
14:40:20 <bwolfe> and which line gets the error
14:40:33 <jacobb> i still have the same thing
14:40:52 <jacobb> and the error comes on saveObs line 47 http://pastebin.com/d6e9d4cdf
14:42:21 <bwolfe> jacobb: error ?
14:42:29 <bwolfe> jacobb: pastebin the stacktrace
14:42:35 <jacobb> oh ok sec
14:44:26 <jacobb> code: http://pastebin.com/d28b97bcd error: http://pastebin.com/d66960967
14:45:11 <jacobb> EncounterFormController.java:254 = my new pastebin at line 47
14:48:59 <bwolfe> jacobb: so if you take out lines 6 to 43 it still fails ??
14:52:57 <jacobb> haha no
14:53:06 <jacobb> it only fails when i try to update an existing obs
14:53:34 <jacobb> i just took out the for loop and change it to get the Obs by ID (hardcoded) b/c i know which one i'm trying to modify and it still failed
14:54:41 <bwolfe> jacobb: must be something wrong with the saveObs method then
15:04:45 <jacobb> hmm
15:04:51 <jacobb> not sure what else i can try, very strange
15:04:57 <jacobb> any ideas for a workaround?
15:06:39 <bwolfe> negative
15:15:55 <jacobb> ugh...i guess i could manually add a new one and void out the old one
15:16:30 <jacobb> but then there's no sort of linking between them, is there any sort of linking done with the saveObs way?
15:18:55 <bwolfe> jacobb: yeah, it appends something to the editReason
15:19:09 <jacobb> hm
15:19:12 <bwolfe> jacobb: theres a ticket out to add a voided_obs column linking it I think
15:19:18 <jacobb> also, i doubt i'll be able to setVoided either
15:19:28 <jacobb> if i cant' call saveObs with a diff obs
15:19:34 <jacobb> haha
15:22:10 <bwolfe> jacobb: :-/
15:22:25 <bwolfe> jacobb: write up a failing test case
15:22:29 <bwolfe> and a ticket
15:23:37 <jacobb> hm
15:23:41 <jacobb> i can check in my module
15:23:41 <jacobb> lol
15:24:28 <jacobb> if it works for the obsformcontroller it should work for me
15:24:36 <jacobb> so i'm trying to figure that out..
15:26:30 <jacobb> interesting, is it because the obs is underneath encounter and i am trying to do it when the encoutner is being saved?
15:27:19 <bwolfe> jacobb: that shouldn't matter...
15:27:36 *** pearlbear has joined #openmrs
15:27:36 *** ChanServ sets mode: +v pearlbear
15:28:45 <bwolfe> jacobb: but if you're saving the encounter later on, theres no need to call Context.getObsService().saveObs(obs, editReason); right there
15:29:14 <jacobb> i save the encounter first, but i might be able to try changing the order
15:29:48 <jacobb> do i need to manually add it to the encounter list then?
15:30:47 <bwolfe> jacobb: encounter.addObs(..) should do it
15:31:01 <jacobb> unless i'm modifying
15:31:06 <jacobb> then it should be fine though
15:32:01 *** sunbiz has joined #openmrs
15:32:15 <bwolfe> right
15:32:37 <jacobb> so i can just change the values i'm changing in the obs
15:32:41 <jacobb> set edit reason
15:32:47 <sunbiz> bmckown: I just got up from sleep... and realized we could use the getResource().getBundle() method from the Servlet
15:32:47 <jacobb> and call update encounter
15:32:52 <jacobb> and it should handle the rest?
15:33:20 <bwolfe> sunbiz: haha, did you get that in a dream? isn't it about 1am over there?
15:33:29 <sunbiz> 2am
15:33:32 <bwolfe> jacobb: yeah, that sounds right
15:33:40 <jacobb> how do i get the void reason to it, though..
15:33:41 <sunbiz> bwolfe: yes... saw that in a dream
15:33:43 <bmckown> hey, cool, sunbiz
15:33:46 <jacobb> that doesn't make sense to me
15:34:00 <sunbiz> bwolfe: where does the messages.properties load into Ben ??
15:34:09 <sunbiz> I mean how can I access that Bundle ??
15:34:13 <bwolfe> sunbiz: spring does all of that
15:34:27 <bwolfe> sunbiz: so the real solution might be to ask spring some how
15:34:30 <jacobb> in EncounterSeviceImpl i only see it checking if the person or date was changed
15:34:33 <sunbiz> without the Spring... can I access it through some package name ?
15:34:45 <bwolfe> sunbiz: the concept name branch that will be merged soon will give you a way to do it, actually
15:34:50 <bwolfe> sunbiz: (jsut remembered that)
15:34:59 <sunbiz> bwolfe: how ??
15:35:08 <bwolfe> sunbiz: so perhaps just wait and use that after its merged (within the next few weeks)
15:35:50 <bwolfe> jacobb: argh
15:35:56 <sunbiz> bwolfe: okkk... :(
15:36:28 <jacobb> i'm trying to make the saveobs calls before saving encounter
15:36:30 <jacobb> seeing if that maeks a diff
15:36:55 <jacobb> damn, no difference
15:37:25 <sgrannis> nribeka: we have a VM set up
15:37:44 <sgrannis> nribeka: to install OpenMRS on for patient matching testing
15:38:52 <bwolfe> jacobb: whats your whole workflow ?
15:39:17 <jacobb> when the encounter form is saved, it also has some inline obs's
15:39:42 <jacobb> if those are modified, after the standard onSubmit saveEncounter is called, I go ahead and add or update my in line obs's
15:39:59 <jacobb> if they're new, they work fine, i am trying to add the ability for in line editing too but it's not working
15:40:48 <jacobb> the only other reason i can think of that it would have two obs's in teh session is because they are in the reference map on the encounter form...would that make a difference?
15:50:17 <jacobb> i changed the code to pull down a new obs from obsService rather than using the one in encounter and it still didn't work...so maybe i'm looking in the wrong area
15:53:10 <bwolfe> jacobb: not sure what you mean in that last part
15:53:26 <jacobb> so right now in that pastebin code i put
15:53:38 <jacobb> i say encounter.getObs(), modify it, and then call obsService.save
15:53:58 <jacobb> i tried saying obsService.getObs(encounter.getObs().getObsId)
15:54:02 <jacobb> to see if it'd get a new copy
15:54:08 <jacobb> i even tried then evicting the old one
15:54:17 <jacobb> and still had the same issue
15:56:38 <bwolfe> jacobb: again, recreate it in a test case
15:56:53 <bwolfe> thats my best (and final) advice. :-)
15:56:58 <jacobb> haha, alright
15:57:18 <jacobb> module doesn't count as a test case? :)
15:58:24 <bwolfe> um, no :-p
15:58:31 <bwolfe> a test case /in/ a module counts as a test case
15:58:39 <jacobb> haha
15:58:40 <jacobb> alright
15:58:46 <bwolfe> but that still is subpar
15:58:54 <bwolfe> (if the code in question is all core code)
15:59:06 <jacobb> maybe i'm still doign something wrong
15:59:07 <jacobb> not sure
15:59:18 <jacobb> ntos ure if anyone has done anything like this before
16:09:48 <nribeka> sgrannis: how can i access the VM?
16:10:04 <nribeka> -just got back to get something for dinner-
16:15:50 *** sioraiocht has joined #openmrs
16:25:41 *** sgrannis has quit IRC
16:31:29 <r0bby> lh: wanna adopt me? :)
16:31:40 <r0bby> I'm house broken, but i'm expenisve
16:31:47 <r0bby> :>
16:31:48 <OpenMRSBot> Recent updates in the world of openmrs: Nzeyimana Antoine: GSOC NEW UPDATES <http://nzeyi.wordpress.com/2008/07/07/gsoc-new-updates/>
16:32:51 <jacobb> bwolfe, i think i fixed it
16:33:24 <bwolfe> jacobb: gold star for you if you did
16:33:27 <bwolfe> jacobb: what was the problem ?
16:33:36 <jacobb> going to test some more and fix some other issues i have with it, but it looks like it seems to be working if I uncomment line 113 in ObsServiceImpl
16:34:00 <jacobb> i did that, built it and deployed it and tis' working so far
16:34:14 <jacobb> going to debug some more b/c for some reason my old one is being modified too without being voided
16:34:28 <bwolfe> odd
16:36:44 <jacobb> interesitng, that looks to be a bug with openmrs in general...or something produced by uncommenting that line
16:37:29 <jacobb> i'm going to debug mroe and find out for sure and let you know
16:39:48 *** njero has quit IRC
16:43:04 <r0bby> this is gonna be interesting
16:43:15 <r0bby> three ajax calls fired back to bakc
16:43:19 <jacobb> bwolfe: the current trunk of openmrs displays all obs (voided and non voided) on the encounter form, and when you click into them NONE of them show up as voided
16:44:30 <bwolfe> hmm
16:44:40 <bwolfe> are you sure thats not your error jacobb ? :-p
16:45:06 <jacobb> yeah, i unloaded my modules
16:45:09 <jacobb> :)
16:45:15 <jacobb> check it out on your side
16:47:58 <jacobb> according to the db, they're not actually being voided
16:47:59 <jacobb> :)
16:48:11 <jacobb> i'll debug through..
16:50:34 <jacobb> save is being called successfully...don't see why it woudlnt' be voided
16:51:02 <jacobb> if you have a sec, can you check if it happens on your side too with any obs modification?
16:52:17 <bwolfe> jacobb: http://demo.openmrs.org/openmrs/admin/encounters/encounter.form?encounterId=1
16:52:18 <OpenMRSBot> <http://ln-s.net/215g> (at demo.openmrs.org)
16:52:27 <jacobb> ah yes
16:52:36 <jacobb> ty
16:53:21 <jacobb> ugh i hate ff3
16:53:30 <jacobb> yes works there...wtf
16:53:59 <bwolfe> jacobb: fyi, I didn't have any problems when creating that encounter, editing it, creating obs, and then editing obs
16:54:05 <jacobb> yeah, me neither
16:54:18 <jacobb> yet on mine, where i added that obsServiceImpl line
16:54:18 <jacobb> i do
16:59:37 <r0bby> hmm this probably is bad that i'm firing 4 ajax calls one after the other
17:00:20 *** sioraiocht has quit IRC
17:00:34 <bwolfe> r0bby: yes, thats a bad sign :-p
17:01:58 <r0bby> I found parsing one piece of data at a time easier :)
17:02:13 <bwolfe> so then have 4 different pages with a controller for each :-)
17:02:19 <bwolfe> (at least thats how I envisioned it)
17:02:32 <r0bby> ...why?
17:02:38 <bwolfe> then its a wizard type of interface
17:02:42 <r0bby> I don't wanna do it that way
17:03:17 <r0bby> blame burke for this design
17:03:42 <r0bby> im following his workflow spec :)
17:04:00 <r0bby> it's all on one page
17:04:04 <r0bby> i know you hate it
17:04:10 <r0bby> and not sure how burke is on this deal
17:04:25 <r0bby> I've blogged it
17:05:18 <r0bby> there 4 calls
17:05:26 <r0bby> 1 to DWR; 4 to my servlet
17:05:41 <r0bby> er 3*
17:05:47 <r0bby> 3 to my servlet
17:05:55 <r0bby> at this rate i just want this working
17:06:03 <r0bby> we can re-factor the hell out of this
17:06:11 <r0bby> but right now i just want this part *DONE*
17:06:13 <sunbiz> bwolfe: have u noticed that if I have a find/create patient page open...and the session expires... I can type something on the field... and an exception is thrown ?
17:07:12 <bwolfe> r0bby: sounds good. as long as you know refactoring is a possibility :-)
17:07:35 <bwolfe> sunbiz: I thought it failed quietly
17:07:43 <bwolfe> sunbiz: and just didn't return any patients
17:08:15 <jacobb> ff3 + openmrs ftl :(
17:09:13 <r0bby> bwolfe: by possibility you mean certainty
17:09:18 <r0bby> jacobb: no
17:09:22 <r0bby> i use ff3 just fine
17:09:25 <r0bby> it's all you
17:09:33 <r0bby> you teh point of failure!
17:09:35 <jacobb> haha
17:09:36 <bwolfe> jacobb: ha. "encounter" the problem yet?
17:09:40 <bwolfe> err yet=again
17:09:42 <sunbiz> bwolfe: yes it doesnt return any patients... but tomcat throws exception...
17:09:46 <jacobb> yes bwolfe all the time
17:09:47 <jacobb> on the demo site too
17:09:55 <jacobb> and on other computers
17:09:55 <jacobb> lol
17:09:58 <bwolfe> sunbiz / jacobb: interesting
17:10:00 <sunbiz> bwolfe: something like IllegalStateException I think
17:10:03 <r0bby> jacobb: for you -> http://openactive.org/fail.jpg
17:10:04 <r0bby> :)
17:10:14 <r0bby> sunbiz: to be expected that's thrown by the container
17:10:15 <jacobb> haha
17:10:29 <sunbiz> r0bby: yes
17:10:36 <bwolfe> sunbiz: open a ticket for it
17:10:42 <r0bby> but openmrs should nip that in the butt
17:10:43 <r0bby> =)
17:10:44 <bwolfe> sunbiz: thats a hard one to test though. :-)
17:11:04 <sunbiz> we can redirect if expired
17:11:19 <sunbiz> bwolfe: just like we redirect normally when not logged on
17:12:09 <sunbiz> any1 knows a way to convert JSP taglibs to Java Code ??
17:12:11 <jacobb> bwolfe: adding/uncommenting line 113 of ObsServiceImpl causes a new obs to be added and the old one to NOT be modified
17:12:11 <r0bby> sunbiz: that'd need to be coded into the AJAX
17:12:13 <jacobb> any idea why?
17:12:26 <r0bby> sunbiz: you shouldn't be putting java code into JSP
17:12:30 <jacobb> that line needs to be there in order to prevent the nonunique exception
17:12:32 <r0bby> ..EVER...
17:12:46 <sunbiz> no... on my Controller Servlet
17:12:50 <bwolfe> jacobb: was that through the obsformcontroller?
17:12:54 <jacobb> yeah
17:13:08 <jacobb> that's why i was seeing that weird behavior
17:13:20 <r0bby> sunbiz: business logic should have no place in your view....
17:13:31 <jacobb> turns out if that line is there it doesn't void them out or save your comment to your voided one
17:13:39 <jacobb> it still adds the new one fine, however
17:14:03 <jacobb> r0bby, how often do you use the encounterForm and obsForm in firefox 3?
17:14:06 <r0bby> BOOYAH NPE!
17:14:13 <r0bby> never
17:14:20 <jacobb> well there you go
17:14:25 <jacobb> :)
17:14:36 <sunbiz> bwolfe: another problem is that getPatient won't return anything in the List if phrase is less than 3 characters... How do I find a patient with name "Su" ???
17:14:37 <jacobb> go use any form that has the provider widget and experience an unuseable openmrs :)
17:15:41 <bwolfe> sunbiz: openmrs does not like people with two character names
17:15:51 <sunbiz> bwolfe: ok...
17:15:53 <jacobb> lol
17:15:53 <bwolfe> :-)
17:16:21 <r0bby> bwolfe: what if my name is Hu
17:16:33 <r0bby> I once knew a black dealer whose name was Hung
17:16:39 <sunbiz> bwolfe: then probably I'll add a msg that asks the patient to add another letter to the name ... ok ??
17:16:48 <r0bby> me in my goofy drowsy state of mind started making cracks
17:17:11 <bwolfe> sunbiz: I think there is a ticket already out there for the minimum character search to be user settable
17:17:40 <bwolfe> sunbiz: and actually, there might be a ticket for the timeout patient/create thing
17:17:44 <sunbiz> thats for the UI I think... is it for the PatientService as well
17:18:09 <bwolfe> sunbiz: it is checked in both places I think. but the patch only addresses one of them
17:22:07 * r0bby sighs
17:22:11 <r0bby> something is goin on
17:22:12 <r0bby> :/
17:23:33 <r0bby> bwolfe: if this works
17:23:43 <r0bby> I'm one step away from completion :)
17:23:46 <r0bby> sort of
17:24:01 <r0bby> why is this harder than I thought?
17:24:18 <jacobb> bwolfe: who would know about that obs saving issue?
17:24:32 <bwolfe> jacobb: heh, me
17:24:38 <jacobb> b/c it looks like Context.evictFromSession(obs); should be called, but it's commented out
17:24:42 <jacobb> do you know why it's commented out?
17:24:46 <jacobb> there's a TODO on it
17:25:01 <bwolfe> I can't remember why (if it was me that did it)
17:25:20 <jacobb> well, when i uncomment it and modify an obs, a new one is saved but hte old one isn't voided
17:25:35 <jacobb> so that's probably why...but not sure why that would be caused
17:25:36 * r0bby evicts jacobb from life
17:25:45 * r0bby snickers
17:28:10 <bwolfe> jacobb: that would be a good reason to have it commented out
17:28:35 <jacobb> haha, yeah...looking into it though, shouldn't voiding it already have been persisted by that point?
17:28:43 <jacobb> voidObs() is called
17:29:04 <bwolfe> jacobb: I'm guessing its because that method appears to be relying on hibernate's "save all objects modified in the session when closing a session" feature
17:29:22 <jacobb> which one, voidObs()?
17:29:45 <jacobb> voidObs calls the dao.saveObs() with the voided obs
17:29:50 <bwolfe> hmm, true
17:30:35 <jacobb> and the hibernateobsdao has sessionFactory.getCurrentSession().saveOrUpdate(obs);
17:30:57 <jacobb> maybe if that session is still open and evict is called, changes aren't saved?
17:34:36 <bwolfe> jacobb: that seems wonky if that is what happens
17:34:55 <jacobb> that looks to be the issue...how would we ensure the session is closed when voidObs() is called before evicting the old obs
17:34:58 <bwolfe> jacobb: but I think the flush isn't happening until the end of the session
17:37:41 <bwolfe> jacobb: so the saveOrUpdate() call doesnt' really do anything :-p
17:37:56 <jacobb> hahah, that's what it appears?
17:38:05 <jacobb> wonderful
17:38:06 <jacobb> lol
17:38:37 <bwolfe> I really wish there was a way to make it so that the only items saved in a session are ones that were "marked" with a call to saveOrUpdate()
17:39:35 <jacobb> yeah...hibernate takes away a lot of control from the user
17:39:51 <jacobb> and is sometimes more of a pain in the ass than it's worth
17:40:40 <jacobb> b/c in order to call saveObs from my module, that evict line has to be there...
17:40:53 <jacobb> yet if i evict, then it ignores the save that was called right before it
17:41:15 <bwolfe> heh, a nice catch 22 there
17:41:48 <jacobb> i think either way, that evict should be there
17:41:57 <jacobb> so it'd be nice to figure out how to force the saving
17:42:24 *** sunbiz has left #openmrs
17:45:25 * r0bby sighs
17:45:44 *** sioraiocht has joined #openmrs
17:49:53 *** TorLye has quit IRC
17:53:31 <jacobb> bwolfe: i got it working without evicting
17:53:58 <jacobb> the issue (i believe) was that the encounter issue was still attached
17:54:11 <jacobb> and then obs from it was then also...
17:54:12 <bwolfe> encounter "issue" ?
17:54:23 <jacobb> oops just "encounter"
17:54:27 <jacobb> if (existingObs.getConcept().equals(conceptByName)) {
17:54:28 <jacobb> obs = Obs.newInstance(existingObs);
17:54:28 <jacobb> obs.setObsId(existingObs.getObsId());
17:54:33 <jacobb> doing that resolved it
17:54:46 <jacobb> even though saveObs does the same thing... =\
17:55:29 <jacobb> the problem was that I was just saying obs = encoutner.getObs()
17:55:34 <jacobb> then modifying that obs, and calling save
17:56:08 <jacobb> i think later, when actually committing the session, it was ALSO trying to persist the changes i made to the obs object i retrieved, and saveObs might not have even been necessary
17:56:18 <jacobb> not really sure on all the specifics why...but doing Obs.newInstance resolved it
17:56:24 <jacobb> and then manually setting the ID
17:56:35 <jacobb> clear as mud?
17:56:36 <bwolfe> hmm
17:56:38 <bwolfe> makes sense
17:56:49 <bwolfe> does the encounter save later not overwrite ?
17:57:02 <jacobb> there wasn't even an encounter save later...that
17:57:06 <jacobb> that's the odd part
17:58:28 <r0bby> bwolfe: is it possible to get the currently logged in user's username from JSP?
17:58:40 <bwolfe> jacobb: but referencing my comment earlier, it doesn't matter. hibernate saves all modified objects in the session
17:59:00 <bwolfe> r0bby: its done in the header
17:59:15 <r0bby> no, i need to pass it as a param to a DWR method
17:59:17 <bwolfe> r0bby: there is a taglib for it. go check the header.jsp files
17:59:23 <r0bby> ah ok
18:00:33 <jacobb> yeah, that's what made me think of that
18:00:38 <jacobb> so i guess this resolves the issue
18:00:46 <jacobb> a little strange that it'd be required...but yeah
18:02:44 <r0bby> oh I can ${authenticatedUSer.userName}
18:03:23 <bwolfe> jacobb: so the real fix is to tell hibernate to only save objects that have been passed to saveOrUpdate
18:03:37 <bwolfe> jacobb: a fix to that would make me sleep better at night. :-)
18:04:07 <jacobb> yeah
18:04:11 <jacobb> agreed
18:11:26 *** sioraioc_ has joined #openmrs
18:12:28 *** sioraio__ has joined #openmrs
18:14:02 *** atomicturtle has quit IRC
18:15:51 *** sioraio__ is now known as sioraiocht_
18:24:29 *** sioraiocht has quit IRC
18:29:54 *** sioraioc_ has quit IRC
18:30:57 <r0bby> don't kill me for doing this but a scriptlket is easier
18:32:36 <bwolfe> r0bby: easier than what?
18:32:48 <r0bby> I don't feel like using the taglib
18:33:11 <r0bby> <%= Context.getAuthenticatedUser().getUserName() %>
18:33:16 <r0bby> nothing bad is gonna happen
18:33:23 <r0bby> the bad taste in my mouth will go away too
18:33:24 <bwolfe> how is that easier than the ${authenticatedUSer.userName} ??
18:34:18 <r0bby> it didn't work..
18:35:51 <r0bby> http://eugeneciurana.com/pastebin/pastebin.php?show=28671
18:35:52 <OpenMRSBot> <http://ln-s.net/2173> (at eugeneciurana.com)
18:35:56 <r0bby> what's wrong here.. :/
18:36:25 <bwolfe> <openmrs:authentication>${authenticatedUser.personName}</openmrs:authentication>
18:36:44 <r0bby> ah ok
18:39:55 <r0bby> I like writing javascript
18:40:03 <r0bby> I really LOVE DWR it's useful
18:41:00 <r0bby> I think something is going on
18:42:55 <r0bby> okay..
18:42:56 <r0bby> help here
18:43:41 <r0bby> if this doesn't work i'm just gonna /gg
18:43:43 <r0bby> er
18:43:51 <r0bby> er im gonna go back to the servlet
18:43:53 <r0bby> but..
18:44:05 <r0bby> bwolfe: i want the username, not the person name
18:44:10 <r0bby> so "admin"
18:44:19 <r0bby> or should i use personName ?
18:44:45 <bwolfe> r0bby: um, ${authenticatedUser.username}
18:44:59 <bwolfe> or maybe ${authenticatedUser.userName}
18:45:49 <r0bby> im spoiled by code completion
18:46:09 <bwolfe> r0bby: I refuse to be your code completion.
18:46:24 <r0bby> im not asking for that!
18:46:37 <r0bby> tho how much do you want?
18:46:49 <r0bby> I got 2k coming my way if i can get this thing working :P
18:46:58 <bwolfe> $25 per question
18:49:30 <r0bby> no cigar :<
18:51:48 <r0bby> meh back to servlet
18:53:24 * r0bby loves his Local History
18:55:07 *** bmckown has quit IRC
18:55:43 *** bwolfe has quit IRC
19:34:48 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Tickets: Ticket #879 (task closed): modulerepository: delete option for added modules <http://dev.openmrs.org/ticket/879#comment:3>
19:55:37 *** docpaul has joined #openmrs
19:55:37 *** ChanServ sets mode: +o docpaul
19:55:45 <docpaul> hi!
19:56:48 <docpaul> what's up folks? :)
19:58:14 <r0bby> hi =)
19:58:29 * r0bby is fighting w/ his app
19:58:47 <docpaul> wassup robbo? :)
19:58:51 <docpaul> how're things?
19:58:58 <r0bby> not too good
19:59:09 <docpaul> got anything to look at, at this point? :)
19:59:17 <r0bby> a lil bit
19:59:26 <docpaul> something i could login to and check out?
19:59:39 <r0bby> hold on let me get it back into some kind of shape
20:00:03 <r0bby> right now you're gonna gonna some ajax quirks it's not behaving right but it'll givbe you an idea
20:00:07 <r0bby> let me open the port
20:00:25 <docpaul> lead the way, master
20:01:04 <docpaul> has lh been around recently?
20:01:10 <r0bby> http://mybawx.org:83/openmrs
20:01:21 <r0bby> you know the standard credentials for a demo system
20:01:26 <docpaul> k
20:01:41 <r0bby> wont say them here as that's a world-facing port right now
20:02:02 <r0bby> First, you'll fill in your class
20:02:10 <r0bby> everything happens when you lose focus on the field
20:02:18 <r0bby> so go the Model field
20:02:28 <docpaul> edit button doesnt work eh?
20:02:30 <r0bby> just hit tab (leave it as-is)
20:02:42 <r0bby> Nope
20:02:52 <r0bby> It's on my list
20:02:58 <docpaul> oh neat
20:03:06 <docpaul> what properties work?
20:03:17 <r0bby> Now -- define a field String str (no semi-colon needed now lose focus
20:03:24 <r0bby> (tab)
20:03:37 <r0bby> you should see my crap template system right now
20:03:52 <r0bby> Okay now type this into the field class Foo { String }
20:03:59 <r0bby> now tab
20:04:07 <r0bby> you'll see the syntax error exception msg
20:04:33 <docpaul> neat
20:04:33 <r0bby> line numbers are off since i do some implicit imports when i run it through the GroovyClassLoader
20:04:40 <r0bby> this is all done via AJAX
20:04:55 <r0bby> also
20:05:04 <docpaul> how does it feel to do something practical vs. conceptual?
20:05:07 <docpaul> kinda cool eh?
20:05:21 <r0bby> on the manage page if you tick the publish
20:05:24 <r0bby> difficult
20:05:28 <r0bby> burke is awol a lot
20:05:39 <docpaul> he's had some family matters to deal with
20:05:45 <docpaul> but he'll be back in force this week
20:05:55 <r0bby> I already did my midterm survey
20:06:11 <r0bby> this is 100% safe since i don't evaluate
20:06:29 <r0bby> I had to define two abstract classes
20:06:42 <r0bby> also you'll be able to do Concept c = "WEIGHT IN (KG)".concept()
20:07:17 <docpaul> right
20:07:22 <r0bby> String.metaClass.concept << {
20:07:22 <r0bby> Context.conceptService.getConceptByName(delegate)
20:07:23 <r0bby> }
20:07:26 <r0bby> code to do it
20:08:01 <r0bby> I also use them to add in bindings to the services -- GroovyShell doesn't work too well when you're dealing w/ classes
20:08:27 <r0bby> a HUGE chunk of my code is in groovy
20:08:40 <r0bby> Once i found out IDEA's groovy support was pretty damn good
20:08:53 <r0bby> my tests are also in groovy
20:09:32 <r0bby> the biggest hurdle for me right now is templating
20:10:18 <r0bby> and testing that forget it -- the expected output and such gets weird since i use here-doc strings (multi-line strings) for defining the controller
20:10:20 <docpaul> well, that's interesting
20:10:40 <docpaul> i wouldnt have imagined that you could do so much in groovy
20:10:53 <r0bby> my servlet is also in groovy
20:11:18 <r0bby> my container class I use for storing property data (name, value, type)
20:11:21 <r0bby> is in groovy
20:11:31 <docpaul> i'm still having a hard time conceptualizing what the java/groovy interaction is... does the groovy source immediately compile to java classes, such that it's a wash?
20:11:57 <docpaul> i dont know enough about groovy to know if it's runtime vs. compiletime
20:12:13 <r0bby> groovy compiles down to java bytecode; it's magic happens via its Meta-Object Protocol all dynamic properties are added the class's associated MetaClass
20:12:42 <r0bby> I have this all compiling side-by-side via the groovyc joint-compiler ant task
20:12:59 <r0bby> the one thing interesting about groovy is if a method doesn't exist
20:13:02 <r0bby> it'll compile
20:13:07 <r0bby> but at runtime will blow up
20:13:15 <r0bby> int x = "three"; // compiles fine
20:13:32 <r0bby> it will blow up @ runtime
20:13:34 <docpaul> that's kinda icky
20:13:44 <r0bby> yeh
20:13:47 <r0bby> price you pay
20:14:04 <r0bby> I'm able to Context.userService to get the UserService instance
20:14:07 <docpaul> my guess is that will evolve as groovy evolves
20:14:17 <r0bby> possibly
20:14:18 <docpaul> so you're testing often
20:14:29 <r0bby> I'm running it to see if works
20:14:42 <r0bby> testing the template output is difficult
20:14:52 <docpaul> it's a bit like writing perl scripts though. :)
20:15:03 <docpaul> you dont know your errors until you run the code
20:15:04 <r0bby> I used Junit4
20:15:21 <r0bby> IDEA is good about warning me
20:15:30 <r0bby> when a method doesn't exist and such
20:16:27 *** pombreda has quit IRC
20:17:19 <docpaul> anyways. :)
20:17:54 <docpaul> ever hear from Burke about the euphemism of "the floss across the chasm"?
20:18:05 <docpaul> it's one of our favorites
20:18:06 <docpaul> :)
20:19:15 <r0bby> repeatedly
20:19:35 <r0bby> It's why i'm not concerned with the fact that i'm probably abusing ajax
20:20:21 *** bwolfe has joined #openmrs
20:20:21 *** ChanServ sets mode: +o bwolfe
20:21:23 <r0bby> docpaul: http://mybawx.org/mixin
20:21:57 <r0bby> that's a groovy script i wrote disassebmled
20:22:15 <r0bby> http://mybawx.org/mixin.groovy is the class
20:22:31 <r0bby> i wanted to play with a change made to groovy in svn at the time
20:22:50 <r0bby> so I did it in the most unsavory way possible
20:25:02 <r0bby> bwolfe: you wanna see what I've been doing?
20:25:20 <r0bby> before i close the port
20:25:25 <bwolfe> sure, you have a demo running?
20:25:34 <r0bby> http://mybawx.org:83/openmrs
20:25:42 <r0bby> you know the standard test auth data
20:25:45 <bwolfe> ooo, awesome interface
20:26:04 <r0bby> bwolfe: I own that and will for as long as i live
20:26:15 <r0bby> I dont care if i go bankrupt
20:26:34 <r0bby> domain -> food -> meh shelter is so overrated
20:26:49 <r0bby> 1) go to Create Form
20:27:00 <r0bby> there are no buttons til you get to the LAST point where its time to save it
20:27:19 <r0bby> just grab focus on the model field
20:27:21 <r0bby> then just tab off
20:27:31 <r0bby> that's candy point 1
20:27:46 <r0bby> candy point 2 is now define 1 field called it String str
20:27:59 <bwolfe> sure wish there was a button here... :-p
20:28:12 <r0bby> it introduced problems for me
20:28:17 <r0bby> I didn't feel like dealing with them
20:28:34 <bwolfe> i'm confused
20:28:38 <bwolfe> how do I make a new form ?
20:28:40 <r0bby> so for now: bite me; anyways moving on
20:28:51 <r0bby> what do you mean? new form?
20:28:53 <r0bby> it's not there yet
20:29:14 <r0bby> I'll add a reset link
20:29:27 <r0bby> anyways
20:29:40 <r0bby> now let's define some code that will break
20:29:44 <r0bby> class Foo { String }
20:30:04 <r0bby> you'll see an exception msg w/ line numbers all screwy
20:30:24 <bwolfe> I see no exception message
20:30:25 <r0bby> I inject some imports into the code before i pass it off to the classloader to parse
20:30:29 <bwolfe> just something in the status bar
20:30:36 <r0bby> you should
20:30:56 <r0bby> oh great i busted it
20:31:29 <r0bby> <result>
20:31:29 <r0bby> Exception: startup failed, script1215480651312.groovy: 4: unexpected token: String @ line 4, column
20:31:32 <r0bby> 15.
20:31:33 <r0bby> there's the ajax
20:31:36 <r0bby> 1 error
20:31:38 <r0bby> </result>
20:31:42 <bwolfe> https://www.slashtmp.iu.edu/public/download.php?FILE=bawolfe/513611C109a
20:31:43 <OpenMRSBot> <http://ln-s.net/218Q> (at www.slashtmp.iu.edu)
20:32:32 <r0bby> yeh i busted the output
20:32:43 <r0bby> so yeh.
20:32:51 <r0bby> go to the Manage page now
20:33:01 <r0bby> Edit button doesn't work dont try it
20:33:31 <bwolfe> too late
20:33:36 <r0bby> tick the published button (that will set the form to published/unpublished depending on how its current state is)
20:34:08 <r0bby> Backup Form and Backup All Forms
20:34:28 <r0bby> simply creates the groovyforms.xml and metadata.xml for the form's current state.
20:34:48 <r0bby> that's all the features i could think of when i was making that page
20:34:53 <r0bby> still need the patient dash
20:36:16 <r0bby> I will add a link to reset the form -- I can't figure out how to STOP the form from being submitted when the button is clicked
20:36:32 <r0bby> s/clicked/pressed/
20:36:39 <r0bby> anyways
20:36:46 <r0bby> i'm gonna close this port you can't do much damage :)
20:36:52 <r0bby> i dont eval the code :)
20:36:58 <r0bby> I just parse it
20:37:20 <bwolfe> ok, good first step :-)
20:37:31 <bwolfe> I'll consider letting you pass ;-)
20:38:26 <r0bby> you determine if i pass?
20:39:50 <r0bby> fail me and i quit!
20:40:03 * r0bby wouldn't fail anyways
20:40:06 <r0bby> I'm god
20:44:38 <docpaul> hi ben
20:44:53 <bwolfe> hey paul
20:45:06 <bwolfe> r0bby: actually, I don't think I have any say in your status
20:45:21 <bwolfe> r0bby: its all on burke
20:45:29 <bwolfe> docpaul: you're on early :-)
20:45:40 <docpaul> will's in bed
20:45:45 <docpaul> mommy is working
20:46:00 <docpaul> daddy is trying to catch up
20:46:47 <bwolfe> docpaul: haha, after a week off you're fighting an uphill battle
20:46:48 <docpaul> robby: don't worry, we ignore most of ben's opinions
20:46:56 <docpaul> bw: tell me about it. :)
20:47:25 <docpaul> thanks for stepping up in a number of ways, btw, ben... it's noticed and appreciated
20:47:55 <bwolfe> docpaul: happy to do it as long as you find me some coders for occ ;-)
20:48:02 <docpaul> working on it
20:48:08 <docpaul> seriously
20:48:46 <bwolfe> actually I can probably get to it
20:48:58 <bwolfe> I just have a large backup of tickets/patches/etc.
20:49:13 <docpaul> let's get 1.3 out the door
20:49:22 <docpaul> that's 1st through 100th priority
20:49:25 <bwolfe> ...and I'm liking this noncoding work a lot more than I thought I would :-)
20:49:56 * r0bby sighs
20:49:58 <docpaul> with more responsibility comes more pain when things aren't completed. :) you'll see
20:50:14 <r0bby> docpaul: i did open one ticket to upgrade DWR
20:50:14 <bwolfe> docpaul: yep, totally agree. 1.3 is in limbo while people test it in the real world thought, so no more to do on that for now
20:50:35 <r0bby> which is outright refuse to do on grounds that its too tedious
20:50:55 <bwolfe> r0bby: sometimes life is like that though
20:50:57 <bwolfe> :-)
20:51:04 <bwolfe> (unfortunately)
20:51:13 <r0bby> yeh well -- I have a choice in this matter :>
20:51:15 <docpaul> not meant as micromanagement, but... passive waiting for the "real world test" to complete is hazardous
20:51:43 <docpaul> wherebe the leslie?
20:51:58 <r0bby> far from me :)
20:52:31 <bwolfe> docpaul: she's been silently lurking all day
20:52:43 <docpaul> she wanted to talk...
20:52:48 <docpaul> trying to find her online
20:53:12 * r0bby knows it's regarding me
20:53:20 <r0bby> er him
20:53:34 <r0bby> I did make one comment in one of sunbiz's threads
20:53:35 <docpaul> robby: nah... she's already complained about you a few other times
20:53:37 <docpaul> :)
20:53:41 <r0bby> she has?
20:53:45 <docpaul> hheh
20:53:50 <r0bby> oh yeh she did CC burke one time
20:53:54 <docpaul> oh god, you have no idea
20:54:10 <r0bby> I'm a manageability nightmare
20:54:22 <r0bby> adhd is a bitch sometimes :/
20:54:23 <docpaul> tell me about it.... thank god you're a good person
20:54:35 <docpaul> ;)
20:54:46 <r0bby> the impulsivity bit is a bit meh
20:55:05 <docpaul> step #1 is acknowledging it. :)
20:55:11 <docpaul> i was kidding btw
20:55:24 <r0bby> yeh i know
20:56:03 <r0bby> I had an interview a couple weeks ago :)
20:56:06 <r0bby> demo'd my ass
20:56:08 <r0bby> er app
20:56:13 <docpaul> hehe
20:56:22 <docpaul> did you wipe beforehand?
20:57:09 <r0bby> joking aside -- i didnt have much to show :/
20:57:31 <r0bby> I've done a lot of work on the backend of things -- not much on the front-end til recently
20:58:16 <r0bby> I showed them it
20:58:24 <r0bby> then kinda had to tell them what will happen
20:58:44 <r0bby> I gave him burke's # for a reference (he asked)
20:59:23 <r0bby> barring burke giving me a reference he finds favorable; and an interview w/ the team id be working w/ i should get it -- i doubt i will -- but i wanted to at least try
20:59:39 <r0bby> they said they won't decide til after soc ends
20:59:51 <r0bby> meh
21:00:37 <bwolfe> r0bby: they want to see if you pass probably :-)
21:01:12 <r0bby> pass what the tech portion?
21:01:45 <r0bby> i went in VERY unsure the entire time just wondering WHYYY on god's green earth i was there
21:02:51 <r0bby> =/
21:05:41 *** atomicturtle has joined #openmrs
21:21:57 *** sgrannis has joined #openmrs
21:22:12 <docpaul> shaun-o
21:22:13 *** ChanServ sets mode: +v sgrannis
21:22:15 <sgrannis> yo
21:22:21 <docpaul> did i miss anything more this afternoon?
21:22:31 <sgrannis> 'sup? boyeez?
21:22:33 <docpaul> i had to rescue crystal this afternoon
21:22:36 <docpaul> she got a flat
21:22:37 <sgrannis> n'prob
21:22:41 <sgrannis> oops
21:22:51 <sgrannis> nah - we glt thru person
21:22:54 <sgrannis> and apteitn
21:23:00 <sgrannis> err .. patient
21:23:14 <docpaul> i felt like a couple of times i might have come off too strong today
21:23:18 <docpaul> i hope i was reasonable?
21:23:19 <sgrannis> naw
21:23:25 <sgrannis> think it went well
21:23:33 <docpaul> there are some tough personalities in that group
21:23:37 <sgrannis> u were rezonabl
21:23:46 <sgrannis> ?
21:23:56 <docpaul> just a lot of strong wills
21:23:59 <sgrannis> 'tough'?
21:24:02 <sgrannis> sure
21:24:05 <docpaul> a lot of talking and not a lot of listening
21:24:10 <sgrannis> yep
21:24:25 <docpaul> we'll get there
21:24:38 <sgrannis> yep
21:24:53 <docpaul> anyways, so now that you saved yourself from more CDC doom, what do you really want to do with that time?
21:25:32 <docpaul> so, are people going to continue firing off fireworks for the next month or something? sheesh
21:25:59 <sgrannis> in addition to identity management issues, lets triangulate some high priority areas in OMRS ...
21:26:10 <docpaul> k
21:26:12 <docpaul> what
21:26:17 <docpaul> s your perspective on those?
21:26:20 <sgrannis> yeah - they're still firing 'em off here too ... as a dad it bugs me
21:26:27 <docpaul> totally, me too!
21:26:39 <docpaul> man how things change
21:29:36 <sgrannis> re - my perspective -- would like to see pipeline integration with OMRS. understand WR is working in that, but i can help drive specific use cases, as is the case with BCD
21:29:49 <sgrannis> NCD = NCD
21:29:53 <sgrannis> BCD=NCD
21:30:31 <docpaul> totally
21:30:45 <docpaul> that seems like a really good place for you to be focused
21:31:59 <docpaul> at some level, it'd be sweet to create your own personal funding stream for that
21:32:07 <docpaul> where you were the PI and were calling the shots
21:32:19 <docpaul> independence rules
21:32:34 <sgrannis> yep.
21:32:53 <sgrannis> nribeka: u there?
21:32:59 <docpaul> i'd like to help you with that, if that was your dream
21:33:25 <docpaul> i'm going to have my hands full with openmrs in developing environments
21:33:36 <nribeka> yes sgrannis
21:33:42 <sgrannis> hey nyoman
21:33:43 <docpaul> you could put a lot of energy into that next iteration
21:34:02 * r0bby needs to get back to coding
21:34:06 <nribeka> any comments?
21:34:08 * r0bby has to pack :/
21:34:28 <sgrannis> nribeka: i'd liek to chat about what you think next steps on teh module might be?
21:34:35 <r0bby> it's gonna be so not fun to have to work while i'm visiting my cousin =(
21:34:56 *** lh has quit IRC
21:35:03 <r0bby> hrm
21:35:07 <r0bby> she's back
21:35:11 <sgrannis> docpaul: i'd like to help in developing space as well -- not sure wehat the specific needs are tho
21:35:12 <nribeka> ok. i like the one that you brought from the conference.
21:35:41 <sgrannis> nribeka: whcih one? the review screen?
21:35:45 <nribeka> yeps
21:35:49 <sgrannis> cool
21:35:49 *** lh has joined #openmrs
21:35:57 <sgrannis> wsa hoping you'd like thqt
21:36:04 <docpaul> dere's my lady. :)
21:36:07 <nribeka> i think it will appeal to end user
21:36:17 <lh> hola monsieur
21:36:33 <nribeka> lh: thanks for the documents. i got my CPT letter already :D
21:36:48 <lh> nribeka: excellent
21:36:55 <nribeka> :D
21:37:11 <nribeka> sgrannis: what do you think about the review screen?
21:37:27 * lh waves to sgrannis
21:37:38 <sgrannis> hi lh -- have we met?
21:37:48 <lh> rotflmao
21:37:52 <docpaul> lh = leslie hawthorn
21:37:52 <lh> lh = leslie hawthorn
21:37:53 <lh> so yes
21:37:56 <sgrannis> heheheh]
21:38:00 <lh> sgrannis: i go by lh on the internets
21:38:10 <sgrannis> what's the internet?
21:38:10 <r0bby> yeh i feel weird calling her leslie
21:38:17 <sgrannis> ;)
21:38:28 <lh> i actually am not a fan of the name leslie
21:38:31 <sgrannis> lh: how's life
21:38:44 <lh> i was named after this dude
21:38:44 <lh> http://en.wikipedia.org/wiki/Leslie_Howard_(actor)
21:38:45 <OpenMRSBot> <http://ln-s.net/219B> (at en.wikipedia.org)
21:38:48 <r0bby> lh: off the record, is google NY coming along? or was that one dead in the water?
21:38:51 <lh> sgrannis: very good, thank you
21:38:58 <sgrannis> good
21:38:59 <lh> r0bby: not dead in the water, i just need more hands
21:39:00 <lh> :)
21:39:22 <r0bby> I do know one of the software engineers, assuming he's still there
21:39:34 <lh> who?
21:39:46 <r0bby> Ido Rosen
21:40:12 *** upul has joined #openmrs
21:40:48 <r0bby> or he told me he was gonna work there
21:41:00 <lh> will check in a sec
21:41:30 <r0bby> let me im him and ask
21:42:13 <r0bby> make sure i don't suddenly look like an ass
21:43:15 <r0bby> lh nevermind
21:44:09 <r0bby> he's not
21:44:10 <lh> r0bby: ok
21:45:15 <r0bby> i feel like an ass now
21:54:27 *** bwolfe has quit IRC
22:08:38 *** upul has quit IRC
22:09:12 *** upul has joined #openmrs
23:00:42 *** lh has quit IRC
23:08:17 *** njero has joined #openmrs
23:08:17 *** ChanServ sets mode: +v njero
23:20:02 <r0bby> njero: o/
23:20:41 *** docpaul has quit IRC
23:27:08 *** maveriick has joined #openmrs
23:28:24 *** pearlbear has quit IRC
23:33:28 *** maveriick has quit IRC
23:33:56 *** maveriick has joined #openmrs
  • No labels